[SafeBrowsing] Alternate extensions should also be subject to block list.

chrome/browser/safe_browsing/unverified_download_policy.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/unverified_download_policy.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/metrics/sparse_histogram.h"
@@ skipping 42 matching lines @@
   int uma_file_type =
       download_protection_util::GetSBClientDownloadExtensionValueForUMA(file);
   if (policy == UnverifiedDownloadPolicy::ALLOWED) {
     RecordPolicyMetric("SafeBrowsing.UnverifiedDownloads.Allowed",
                        uma_file_type, requestor);
   } else {
     RecordPolicyMetric("SafeBrowsing.UnverifiedDownloads.Blocked",
                        uma_file_type, requestor);
   }
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-                                   base::Bind(callback, policy));
+                          base::Bind(callback, policy));
 }
 
 void CheckFieldTrialOnAnyThread(
     const base::FilePath& file,
+    const std::vector<base::FilePath::StringType>& alternate_extensions,
     const GURL& requestor,
     const UnverifiedDownloadCheckCompletionCallback& callback) {
-  bool is_allowed = IsUnverifiedDownloadAllowedByFieldTrial(file);
-  RespondWithPolicy(file, callback, requestor, is_allowed
-                                        ? UnverifiedDownloadPolicy::ALLOWED
-                                        : UnverifiedDownloadPolicy::DISALLOWED);
+  if (!IsUnverifiedDownloadAllowedByFieldTrial(file)) {
+    RespondWithPolicy(file, callback, requestor,
+                      UnverifiedDownloadPolicy::DISALLOWED);
+    return;
+  }
+
+  for (const auto& extension : alternate_extensions) {
+    base::FilePath alternate_filename = file.AddExtension(extension);
+    if (!IsUnverifiedDownloadAllowedByFieldTrial(alternate_filename)) {
+      RespondWithPolicy(alternate_filename, callback, requestor,
+                        UnverifiedDownloadPolicy::DISALLOWED);
+      return;
+    }
+  }
+
+  RespondWithPolicy(file, callback, requestor,
+                    UnverifiedDownloadPolicy::ALLOWED);
 }
 
 void CheckWhitelistOnIOThread(
     scoped_refptr<SafeBrowsingService> service,
     const GURL& requestor,
     const base::FilePath& file,
+    const std::vector<base::FilePath::StringType>& alternate_extensions,
     const UnverifiedDownloadCheckCompletionCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   int uma_file_type =
       download_protection_util::GetSBClientDownloadExtensionValueForUMA(file);
 
   if (!service || !service->enabled()) {
     // If the SafeBrowsing service was disabled, don't try to check against the
     // field trial list. Instead allow the download. We are assuming that if the
     // SafeBrowsing service was disabled for this user, then we shouldn't
     // interefere with unverified downloads.
     RecordPolicyMetric(
         "SafeBrowsing.UnverifiedDownloads.AllowedDueToDisabledService",
         uma_file_type, requestor);
     RespondWithPolicy(file, callback, requestor,
                       UnverifiedDownloadPolicy::ALLOWED);
     return;
   }
 
   if (service->database_manager() &&
       service->database_manager()->MatchDownloadWhitelistUrl(requestor)) {
     RecordPolicyMetric("SafeBrowsing.UnverifiedDownloads.AllowedByWhitelist",
                        uma_file_type, requestor);
     RespondWithPolicy(file, callback, requestor,
                       UnverifiedDownloadPolicy::ALLOWED);
     return;
   }
 
-  CheckFieldTrialOnAnyThread(file, requestor, callback);
+  CheckFieldTrialOnAnyThread(file, alternate_extensions, requestor, callback);
 }
 
 }  // namespace
 
 void CheckUnverifiedDownloadPolicy(
     const GURL& requestor,
     const base::FilePath& file,
+    const std::vector<base::FilePath::StringType>& alternate_extensions,
     const UnverifiedDownloadCheckCompletionCallback& callback) {
+  UMA_HISTOGRAM_SPARSE_SLOWLY(
+      "SafeBrowsing.UnverifiedDownloads.AlternateExtensionCount",
+      alternate_extensions.size());

[Steven Holte, 2016/01/25 18:57:29]

Is there a hard limit somewhere on how large this can be?  The data will be
harder to process if we get many distinct values, so it would be good to add
std::min(some_limit, alternate_extensions.size()) before recording.

[asanka, 2016/01/25 19:53:42]

Done. I added a limit of 16.

   if (requestor.is_valid()) {
     scoped_refptr<SafeBrowsingService> service =
         g_browser_process->safe_browsing_service();
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&CheckWhitelistOnIOThread, service, requestor, file,
-                   callback));
+                   alternate_extensions, callback));
     return;
   }
 
-  CheckFieldTrialOnAnyThread(file, GURL(), callback);
+  CheckFieldTrialOnAnyThread(file, alternate_extensions, GURL(), callback);
 }
 
 }  // namespace safe_browsing