Replace TestingProfile::GetCookieMonster with GetCookieStore.

Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
Committed: https://crrev.com/61ceb531398741fd759a11f0cc0de26f469c4619
Cr-Commit-Position: refs/heads/master@{#370779}

[mmenke, 2016-01-20 22:05:59]

Description was changed from

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

BUG=579653
==========

to

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

[mmenke, 2016-01-20 22:16:12]

Patchset #3 (id:40001) has been deleted

[mmenke, 2016-01-20 22:45:44]

mmenke@chromium.org changed reviewers:
+ mkwst@chromium.org

[mmenke, 2016-01-20 22:45:45]

mkwst:  PTAL

[Mike West, 2016-01-21 09:17:51]

LGTM, this is nice cleanup. Thanks for small patches. :)

[mmenke, 2016-01-21 16:24:53]

Description was changed from

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

to

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
TBR=sky@chromium.org
==========

[mmenke, 2016-01-21 16:25:52]

Description was changed from

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
TBR=sky@chromium.org
==========

to

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

[mmenke, 2016-01-21 16:27:16]

mmenke@chromium.org changed reviewers:
+ sky@chromium.org

[mmenke, 2016-01-21 16:27:16]

Sky:  This is a test-only API change to chrome/test/base/testing_profile.h,
where we're returning a superclass of what we returned before.  Seems completely
TBRable to me, but I'll give you a day to sign off, just in case, and plan to
land tonight if I don't hear from you.

[sky, 2016-01-21 19:59:47]

LGTM - I'm fine with a TBR for this sort of change in the future.

[mmenke, 2016-01-21 20:00:53]

On 2016/01/21 19:59:47, sky wrote:
> LGTM - I'm fine with a TBR for this sort of change in the future.

ok, will do.

[mmenke, 2016-01-21 20:00:59]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-01-21 20:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1613473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1613473002/60001

[commit-bot: I haz the power, 2016-01-21 20:44:46]

Description was changed from

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

to

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

[commit-bot: I haz the power, 2016-01-21 20:44:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-21 20:45:36]

Description was changed from

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653
==========

to

==========
Replace TestingProfile::GetCookieMonster with GetCookieStore.

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653

Committed: https://crrev.com/61ceb531398741fd759a11f0cc0de26f469c4619
Cr-Commit-Position: refs/heads/master@{#370779}
==========

[commit-bot: I haz the power, 2016-01-21 20:45:37]

Patchset 3 (id:??) landed as
https://crrev.com/61ceb531398741fd759a11f0cc0de26f469c4619
Cr-Commit-Position: refs/heads/master@{#370779}