Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.

Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.

null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650

Reverted: https://code.google.com/p/dart/source/detail?r=32652

Committed: https://code.google.com/p/dart/source/detail?r=32654

Reverted: https://code.google.com/p/dart/source/detail?r=32665

Committed: https://code.google.com/p/dart/source/detail?r=32692

[kasperl, 2014-02-13 07:07:08]

LGTM.

https://codereview.chromium.org/161333002/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/161333002/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:881: var cacheHolder = reflectee == null ?
getInterceptor(null) : reflectee;
() around the comparison?

[karlklose, 2014-02-13 08:20:07]

LGTM.

https://codereview.chromium.org/161333002/diff/1/tests/language/null2_test.dart
File tests/language/null2_test.dart (right):

https://codereview.chromium.org/161333002/diff/1/tests/language/null2_test.da...
tests/language/null2_test.dart:12: try { throw [x]; } on dynamic catch (e) {
return e[0]; }
This may break when the compiler gets smarter. I would prefer
  return new DateTime.now().millisecondsSinceEpoch == 42 ? 42 : null.

[floitsch, 2014-02-13 10:26:30]

https://codereview.chromium.org/161333002/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/161333002/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:881: var cacheHolder = reflectee == null ?
getInterceptor(null) : reflectee;
On 2014/02/13 07:07:08, kasperl wrote:
> () around the comparison?

Done.

https://codereview.chromium.org/161333002/diff/1/tests/language/null2_test.dart
File tests/language/null2_test.dart (right):

https://codereview.chromium.org/161333002/diff/1/tests/language/null2_test.da...
tests/language/null2_test.dart:12: try { throw [x]; } on dynamic catch (e) {
return e[0]; }
On 2014/02/13 08:20:08, karlklose wrote:
> This may break when the compiler gets smarter. I would prefer
>   return new DateTime.now().millisecondsSinceEpoch == 42 ? 42 : null.

Merged yours and the original confuse method. (also in null_test.dart where I
copied this method from).

[floitsch, 2014-02-13 12:39:39]

Committed patchset #2 manually as r32650 (presubmit successful).

[floitsch, 2014-02-13 14:45:30]

PTAL.

One more line (diff patch-set 3 and 4).

[karlklose, 2014-02-13 14:46:12]

LGTM.

[floitsch, 2014-02-13 15:10:23]

Committed patchset #4 manually as r32654 (presubmit successful).

[floitsch, 2014-02-14 12:01:29]

Updated status file for Safari.
Trying to land again.
(TBR)

[karlklose, 2014-02-14 12:05:27]

LGTM.

[floitsch, 2014-02-14 12:08:30]

Committed patchset #8 manually as r32692 (presubmit successful).