Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1613283002: Add readme for build/args directory. (Closed)

Created:
4 years, 11 months ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add readme for build/args directory. Committed: https://crrev.com/858b96471ab1eb4e5c6365d1b0fa1fc6f5d4c7f7 Cr-Commit-Position: refs/heads/master@{#370751}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A build/args/README.txt View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brettw
The readme mentions the directory is empty even though it's not. But the aura_android file ...
4 years, 11 months ago (2016-01-21 18:26:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613283002/1
4 years, 11 months ago (2016-01-21 18:26:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 18:43:29 UTC) #6
tfarina
I like the way you explained it. It was used for Aura on Android (https://chromium.googlesource.com/chromium/src/+/ad26484e8d5ad64a170ca97ea2330044e4168ef8), ...
4 years, 11 months ago (2016-01-21 19:04:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613283002/20001
4 years, 11 months ago (2016-01-21 19:10:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 19:38:19 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:39:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/858b96471ab1eb4e5c6365d1b0fa1fc6f5d4c7f7
Cr-Commit-Position: refs/heads/master@{#370751}

Powered by Google App Engine
This is Rietveld 408576698