Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1613233006: Disable hand-coded assembly in boringssl for armv6 and armv5te (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
Bill Hesse, rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable hand-coded assembly in boringssl for armv6 and armv5te related #25562 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f1748f12fc46b7a9432bbe22eb3358a0922860aa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also diable on arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M third_party/boringssl/boringssl_configurations.gypi View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 11 months ago (2016-01-22 21:57:03 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1613233006/diff/1/third_party/boringssl/boringssl_configurations.gypi File third_party/boringssl/boringssl_configurations.gypi (right): https://codereview.chromium.org/1613233006/diff/1/third_party/boringssl/boringssl_configurations.gypi#newcode81 third_party/boringssl/boringssl_configurations.gypi:81: }, Consider also for arm64 with a TODO(24321).
4 years, 11 months ago (2016-01-22 22:59:34 UTC) #3
zra
https://codereview.chromium.org/1613233006/diff/1/third_party/boringssl/boringssl_configurations.gypi File third_party/boringssl/boringssl_configurations.gypi (right): https://codereview.chromium.org/1613233006/diff/1/third_party/boringssl/boringssl_configurations.gypi#newcode81 third_party/boringssl/boringssl_configurations.gypi:81: }, On 2016/01/22 22:59:34, rmacnak wrote: > Consider also ...
4 years, 11 months ago (2016-01-22 23:03:37 UTC) #4
zra
4 years, 11 months ago (2016-01-22 23:06:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f1748f12fc46b7a9432bbe22eb3358a0922860aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698