Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 161323002: Re-enable prerender_page_with_link tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index f33bd843981afda07759a13310e3b523e9a8f71c..b88a552995ad310e620ddf206dd82b176a295b73 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -1187,15 +1187,13 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {
}
void ClickToNextPageAfterPrerender() {
- content::WindowedNotificationObserver new_page_observer(
- content::NOTIFICATION_NAV_ENTRY_COMMITTED,
- content::NotificationService::AllSources());
+ TestNavigationObserver nav_observer(GetActiveWebContents());
RenderViewHost* render_view_host =
GetActiveWebContents()->GetRenderViewHost();
render_view_host->ExecuteJavascriptInWebFrame(
base::string16(),
base::ASCIIToUTF16("ClickOpenLink()"));
- new_page_observer.Wait();
+ nav_observer.Wait();
}
void NavigateToNextPageAfterPrerender() const {
@@ -1207,9 +1205,7 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {
// Called after the prerendered page has been navigated to and then away from.
// Navigates back through the history to the prerendered page.
void GoBackToPrerender() {
- content::WindowedNotificationObserver back_nav_observer(
- content::NOTIFICATION_NAV_ENTRY_COMMITTED,
- content::NotificationService::AllSources());
+ TestNavigationObserver back_nav_observer(GetActiveWebContents());
chrome::GoBack(current_browser(), CURRENT_TAB);
back_nav_observer.Wait();
bool original_prerender_page = false;
@@ -3108,8 +3104,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
// followed by a navigation to another page from the prerendered page, followed
// by a back navigation.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderNavigateClickGoBack) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderNavigateClickGoBack) {
PrerenderTestURL("files/prerender/prerender_page_with_link.html",
FINAL_STATUS_USED,
1);
@@ -3118,10 +3113,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
GoBackToPrerender();
}
-// Disabled due to timeouts on commit queue.
-// http://crbug.com/121130
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderNavigateNavigateGoBack) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderNavigateNavigateGoBack) {
PrerenderTestURL("files/prerender/prerender_page_with_link.html",
FINAL_STATUS_USED,
1);
@@ -3130,8 +3122,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
GoBackToPrerender();
}
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderClickClickGoBack) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderClickClickGoBack) {
PrerenderTestURL("files/prerender/prerender_page_with_link.html",
FINAL_STATUS_USED,
1);
@@ -3140,10 +3131,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
GoBackToPrerender();
}
-// Disabled due to timeouts on commit queue.
-// http://crbug.com/121130
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderClickNavigateGoBack) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderClickNavigateGoBack) {
PrerenderTestURL("files/prerender/prerender_page_with_link.html",
FINAL_STATUS_USED,
1);
@@ -3166,11 +3154,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderClickNewForegroundTab) {
OpenDestURLViaClickNewForegroundTab();
}
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderClickNewBackgroundTab) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderClickNewBackgroundTab) {
scoped_ptr<TestPrerender> prerender =
PrerenderTestURL("files/prerender/prerender_page_with_link.html",
- FINAL_STATUS_APP_TERMINATING,
+ FINAL_STATUS_WINDOW_OPENER,
1);
ASSERT_TRUE(prerender->contents());
prerender->contents()->set_should_be_shown(false);
@@ -3195,8 +3182,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
// Validate that the sessionStorage namespace remains the same when swapping
// in a prerendered page.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderSessionStorage) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSessionStorage) {
set_loader_path("files/prerender/prerender_loader_with_session_storage.html");
PrerenderTestURL(GetCrossDomainTestUrl("files/prerender/prerender_page.html"),
FINAL_STATUS_USED,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698