Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 161323002: Re-enable prerender_page_with_link tests. (Closed)

Created:
6 years, 10 months ago by davidben
Modified:
6 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Re-enable prerender_page_with_link tests. Rework the wait functions to use a TestNavigationObserver (waits for DidStopLoading) rather than the commit, to avoid potential flakiness where the load is still progressing. (prerender_loader_with_session_storage.html only updates sessionStorage.counter at onload.) BUG=249179, 121130 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 8 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davidben
6 years, 10 months ago (2014-02-12 22:29:06 UTC) #1
mmenke
LGTM.
6 years, 10 months ago (2014-02-13 15:46:38 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 10 months ago (2014-02-13 16:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/161323002/1
6 years, 10 months ago (2014-02-13 16:50:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/161323002/1
6 years, 10 months ago (2014-02-13 19:49:47 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:18:31 UTC) #6
Message was sent while issue was closed.
Change committed as 251124

Powered by Google App Engine
This is Rietveld 408576698