Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: sandbox/linux/services/libc_urandom_override.cc

Issue 16132015: don't override libc code in a glibc-specific way when not using glibc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style fixup Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/libc_urandom_override.cc
diff --git a/sandbox/linux/services/libc_urandom_override.cc b/sandbox/linux/services/libc_urandom_override.cc
index dfb4c269e3ffd10a14f425ceae1580474767372d..67b6b1b617bfb68e7d9349ba8d88497008e065c4 100644
--- a/sandbox/linux/services/libc_urandom_override.cc
+++ b/sandbox/linux/services/libc_urandom_override.cc
@@ -59,6 +59,7 @@ static void InitLibcFileIOFunctions() {
g_libc_fopen64 = g_libc_fopen;
}
+#if defined(LIBC_GLIBC)
// TODO(sergeyu): This works only on systems with glibc. Fix it to
// work properly on other systems if necessary.
g_libc_xstat = reinterpret_cast<XstatFunction>(
@@ -155,6 +156,7 @@ int xstat64_override(int version, const char *path, struct stat64 *buf) {
return g_libc_xstat64(version, path, buf);
}
}
+#endif // LIBC_GLIBC
jln (very slow on Chromium) 2013/06/12 20:27:59 Nit: this should be "// defined(LIBC_GLIBC)"
Mostyn Bramley-Moore 2013/06/12 20:41:41 That doesn't match the format used two lines down,
#endif // !ADDRESS_SANITIZER
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698