Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 16132012: First pass android support in bisect script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from review. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/bisect_utils.py ('K') | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index 42e27a3941fd23eb63df8ec5a0a5b60803b009b3..77f1748d2d30b6079fd2cbe8a193d36ba4fbcfcc 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -81,10 +81,7 @@ def RunBisectionScript(config, working_directory, path_to_file, path_to_goma):
if config['max_time_minutes']:
cmd.extend(['--repeat_test_max_time', config['max_time_minutes']])
- if os.name == 'nt':
- cmd.extend(['--build_preference', 'ninja'])
- else:
- cmd.extend(['--build_preference', 'make'])
+ cmd.extend(['--build_preference', 'ninja'])
if '--browser=cros' in config['command']:
cmd.extend(['--target_platform', 'cros'])
@@ -98,6 +95,9 @@ def RunBisectionScript(config, working_directory, path_to_file, path_to_goma):
print
return 1
+ if '--browser=android' in config['command']:
+ cmd.extend(['--target_platform', 'android'])
+
goma_file = ''
if path_to_goma:
path_to_goma = os.path.abspath(path_to_goma)
« tools/bisect_utils.py ('K') | « tools/prepare-bisect-perf-regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698