Issue 16132004: Have to invalidate the mute button when changing the volume

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16132004: Have to invalidate the mute button when changing the volume (Closed)

Created:
7 years, 6 months ago by cbiesinger

Modified:
7 years, 6 months ago

Reviewers:
ojan

CC:
blink-reviews, feature-media-reviews_chromium.org, eae+blinkwatch, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Have to invalidate the mute button when changing the volume This is because the painting code in RenderMediaControlsChromium.cpp:paintMediaMuteButton depends on the volume, and that code gets called via RenderTheme, so nothing else can invalidate the button. (This is another regression from converting media controls to new-flexbox in http://trac.webkit.org/changeset/142947) R=ojan@chromium.org BUG=245921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151687

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	LayoutTests/fast/repaint/video-mute-repaint-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	LayoutTests/fast/repaint/video-unmute-repaint.html	View		2 chunks	+4 lines, -1 line	0 comments	Download
A	LayoutTests/fast/repaint/video-unmute-repaint-expected.txt	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/html/shadow/MediaControls.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

cbiesinger

7 years, 6 months ago (2013-06-03 19:49:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r151687 (presubmit successful).