Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1613193002: Use correct size for unattached canvases when building canvas filters (Closed)

Created:
4 years, 11 months ago by ajuma
Modified:
4 years, 11 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct size for unattached canvases when building canvas filters The equivalent bug for attached canvases was fixed in http://crrev.com/370047, but unattached canvases were ignored there. BUG=561045 Committed: https://crrev.com/b2595b189d4dd5b1d6df1bf1daece1cbd9de4356 Cr-Commit-Position: refs/heads/master@{#370719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-width-height-off-screen.html View 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/canvas-filter-width-height-off-screen-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ajuma
4 years, 11 months ago (2016-01-21 15:57:55 UTC) #3
Stephen White
LGTM
4 years, 11 months ago (2016-01-21 16:00:37 UTC) #4
Justin Novosad
On 2016/01/21 16:00:37, Stephen White wrote: > LGTM lgtm2
4 years, 11 months ago (2016-01-21 16:01:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613193002/1
4 years, 11 months ago (2016-01-21 16:03:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 17:11:34 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:12:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2595b189d4dd5b1d6df1bf1daece1cbd9de4356
Cr-Commit-Position: refs/heads/master@{#370719}

Powered by Google App Engine
This is Rietveld 408576698