Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1613163002: [interpreter] Wide register support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/register-translator.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/interpreter/bytecode-array-iterator.h" 8 #include "src/interpreter/bytecode-array-iterator.h"
9 #include "src/interpreter/bytecode-generator.h" 9 #include "src/interpreter/bytecode-generator.h"
10 #include "src/interpreter/interpreter.h" 10 #include "src/interpreter/interpreter.h"
(...skipping 1440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 B(Add), R(3), // 1451 B(Add), R(3), //
1452 B(Star), R(2), // 1452 B(Star), R(2), //
1453 B(Ldar), A(2, 3), // 1453 B(Ldar), A(2, 3), //
1454 B(Star), R(3), // 1454 B(Star), R(3), //
1455 B(Call), R(0), R(1), U8(2), U8(vector->GetIndex(slot1)), // 1455 B(Call), R(0), R(1), U8(2), U8(vector->GetIndex(slot1)), //
1456 B(Return), // 1456 B(Return), //
1457 }, 1457 },
1458 1, 1458 1,
1459 {"func"}}, 1459 {"func"}},
1460 {"function f(a) {\n" 1460 {"function f(a) {\n"
1461 " a.func;\n" 1461 " a.func;\n" REPEAT_127(
1462 REPEAT_127(SPACE, " a.func;\n") 1462 SPACE, " a.func;\n") " return a.func(); }\nf(" FUNC_ARG ")",
1463 " return a.func(); }\nf(" FUNC_ARG ")",
1464 2 * kPointerSize, 1463 2 * kPointerSize,
1465 2, 1464 2,
1466 1046, 1465 1046,
1467 { 1466 {
1468 B(Ldar), A(1, 2), // 1467 B(Ldar), A(1, 2), //
1469 B(Star), R(0), // 1468 B(Star), R(0), //
1470 B(LoadICSloppy), R(0), U8(0), U8(wide_idx += 2), // 1469 B(LoadICSloppy), R(0), U8(0), U8(wide_idx += 2), //
1471 REPEAT_127(COMMA, // 1470 REPEAT_127(COMMA, //
1472 B(Ldar), A(1, 2), // 1471 B(Ldar), A(1, 2), //
1473 B(Star), R(0), // 1472 B(Star), R(0), //
1474 B(LoadICSloppy), R(0), U8(0), U8((wide_idx += 2))), // 1473 B(LoadICSloppy), R(0), U8(0), U8((wide_idx += 2))), //
1475 B(Ldar), A(1, 2), // 1474 B(Ldar),
1476 B(Star), R(1), // 1475 A(1, 2), //
1477 B(LoadICSloppyWide), R(1), U16(0), U16(wide_idx + 4), // 1476 B(Star), R(1), //
1478 B(Star), R(0), // 1477 B(LoadICSloppyWide), R(1), U16(0), U16(wide_idx + 4), //
1479 B(CallWide), R16(0), R16(1), U16(0), U16(wide_idx + 2), // 1478 B(Star), R(0), //
1480 B(Return), // 1479 B(CallWide), R16(0), R16(1), U16(0), U16(wide_idx + 2), //
1480 B(Return), //
1481 }, 1481 },
1482 1, 1482 1,
1483 {"func"}}, 1483 {"func"}},
1484 }; 1484 };
1485 for (size_t i = 0; i < arraysize(snippets); i++) { 1485 for (size_t i = 0; i < arraysize(snippets); i++) {
1486 Handle<BytecodeArray> bytecode_array = 1486 Handle<BytecodeArray> bytecode_array =
1487 helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName); 1487 helper.MakeBytecode(snippets[i].code_snippet, helper.kFunctionName);
1488 CheckBytecodeArrayEqual(snippets[i], bytecode_array); 1488 CheckBytecodeArrayEqual(snippets[i], bytecode_array);
1489 } 1489 }
1490 } 1490 }
(...skipping 5784 matching lines...) Expand 10 before | Expand all | Expand 10 after
7275 for (size_t i = 0; i < arraysize(snippets); i++) { 7275 for (size_t i = 0; i < arraysize(snippets); i++) {
7276 std::string script = std::string(function_prologue) + 7276 std::string script = std::string(function_prologue) +
7277 std::string(snippets[i].code_snippet) + 7277 std::string(snippets[i].code_snippet) +
7278 std::string(function_epilogue); 7278 std::string(function_epilogue);
7279 Handle<BytecodeArray> bytecode_array = 7279 Handle<BytecodeArray> bytecode_array =
7280 helper.MakeBytecode(script.c_str(), "*", "f"); 7280 helper.MakeBytecode(script.c_str(), "*", "f");
7281 CheckBytecodeArrayEqual(snippets[i], bytecode_array); 7281 CheckBytecodeArrayEqual(snippets[i], bytecode_array);
7282 } 7282 }
7283 } 7283 }
7284 7284
7285 TEST(WideRegisters) {
7286 InitializedHandleScope handle_scope;
7287 BytecodeGeneratorHelper helper;
7288
7289 // Prepare prologue that creates frame for lots of registers.
7290 std::ostringstream os;
7291 for (size_t i = 0; i < 157; ++i) {
7292 os << "var x" << i << ";\n";
7293 }
7294 std::string prologue(os.str());
7295
7296 ExpectedSnippet<int> snippets[] = {
7297 {"x0 = x127;\n"
7298 "return x0;\n",
7299 161 * kPointerSize,
7300 1,
7301 15,
7302 {
7303 B(MovWide), R16(131), R16(125), //
7304 B(Ldar), R(125), //
7305 B(MovWide), R16(125), R16(131), //
7306 B(Star), R(0), //
7307 B(Return), //
7308 }},
7309 {"x127 = x126;\n"
7310 "return x127;\n",
7311 161 * kPointerSize,
7312 1,
7313 37,
7314 {
7315 B(MovWide), R16(130), R16(125), //
7316 B(Ldar), R(125), //
7317 B(MovWide), R16(125), R16(130), //
7318 B(MovWide), R16(131), R16(125), //
7319 B(Star), R(125), //
7320 B(MovWide), R16(125), R16(131), //
7321 B(MovWide), R16(131), R16(125), //
7322 B(Ldar), R(125), //
7323 B(MovWide), R16(125), R16(131), //
7324 B(Return), //
7325 }},
7326 {"if (x2 > 3) { return x129; }\n"
7327 "return x128;\n",
7328 162 * kPointerSize,
7329 1,
7330 56,
7331 {
7332 B(Ldar), R(2), //
7333 B(MovWide), R16(161), R16(125), //
7334 B(Star), R(125), //
7335 B(MovWide), R16(125), R16(161), //
7336 B(LdaSmi8), U8(3), //
7337 B(MovWide), R16(161), R16(125), //
7338 B(TestGreaterThan), R(125), //
7339 B(MovWide), R16(125), R16(161), //
7340 B(JumpIfToBooleanFalse), U8(15), //
7341 B(MovWide), R16(133), R16(125), //
7342 B(Ldar), R(125), //
7343 B(MovWide), R16(125), R16(133), //
7344 B(Return), //
7345 B(MovWide), R16(132), R16(125), //
7346 B(Ldar), R(125), //
7347 B(MovWide), R16(125), R16(132), //
7348 B(Return), //
7349 }},
7350 {"var x0 = 0;\n"
7351 "if (x129 == 3) { var x129 = x0; }\n"
7352 "if (x2 > 3) { return x0; }\n"
7353 "return x129;\n",
7354 162 * kPointerSize,
7355 1,
7356 103,
7357 {
7358 B(LdaZero), //
7359 B(Star), R(0), //
7360 B(MovWide), R16(133), R16(125), //
7361 B(Ldar), R(125), //
7362 B(MovWide), R16(125), R16(133), //
7363 B(MovWide), R16(161), R16(125), //
7364 B(Star), R(125), //
7365 B(MovWide), R16(125), R16(161), //
7366 B(LdaSmi8), U8(3), //
7367 B(MovWide), R16(161), R16(125), //
7368 B(TestEqual), R(125), //
7369 B(MovWide), R16(125), R16(161), //
7370 B(JumpIfToBooleanFalse), U8(16), //
7371 B(Ldar), R(0), //
7372 B(MovWide), R16(133), R16(125), //
7373 B(Star), R(125), //
7374 B(MovWide), R16(125), R16(133), //
7375 B(Ldar), R(2), //
7376 B(MovWide), R16(161), R16(125), //
7377 B(Star), R(125), //
7378 B(MovWide), R16(125), R16(161), //
7379 B(LdaSmi8), U8(3), //
7380 B(MovWide), R16(161), R16(125), //
7381 B(TestGreaterThan), R(125), //
7382 B(MovWide), R16(125), R16(161), //
7383 B(JumpIfToBooleanFalse), U8(5), //
7384 B(Ldar), R(0), //
7385 B(Return), //
7386 B(MovWide), R16(133), R16(125), //
7387 B(Ldar), R(125), //
7388 B(MovWide), R16(125), R16(133), //
7389 B(Return), //
7390 }},
7391 {"var x0 = 0;\n"
7392 "var x1 = 0;\n"
7393 "for (x128 = 0; x128 < 64; x128++) {"
7394 " x1 += x128;"
7395 "}"
7396 "return x128;\n",
7397 162 * kPointerSize,
7398 1,
7399 152,
7400 {
7401 B(LdaZero), //
7402 B(Star), R(0), //
7403 B(LdaZero), //
7404 B(Star), R(1), //
7405 B(LdaZero), //
7406 B(MovWide), R16(132), R16(125), //
7407 B(Star), R(125), //
7408 B(MovWide), R16(125), R16(132), //
7409 B(MovWide), R16(132), R16(125), //
7410 B(Ldar), R(125), //
7411 B(MovWide), R16(125), R16(132), //
7412 B(MovWide), R16(161), R16(125), //
7413 B(Star), R(125), //
7414 B(MovWide), R16(125), R16(161), //
7415 B(LdaSmi8), U8(64), //
7416 B(MovWide), R16(161), R16(125), //
7417 B(TestLessThan), R(125), //
7418 B(MovWide), R16(125), R16(161), //
7419 B(JumpIfToBooleanFalse), U8(82), //
7420 B(Ldar), R(1), //
7421 B(MovWide), R16(161), R16(125), //
7422 B(Star), R(125), //
7423 B(MovWide), R16(125), R16(161), //
7424 B(MovWide), R16(132), R16(125), //
7425 B(Ldar), R(125), //
7426 B(MovWide), R16(125), R16(132), //
7427 B(MovWide), R16(161), R16(125), //
7428 B(Add), R(125), //
7429 B(MovWide), R16(125), R16(161), //
7430 B(Star), R(1), //
7431 B(MovWide), R16(132), R16(125), //
7432 B(Ldar), R(125), //
7433 B(MovWide), R16(125), R16(132), //
7434 B(ToNumber), //
7435 B(MovWide), R16(161), R16(125), //
7436 B(Star), R(125), //
7437 B(MovWide), R16(125), R16(161), //
7438 B(Inc), //
7439 B(MovWide), R16(132), R16(125), //
7440 B(Star), R(125), //
7441 B(MovWide), R16(125), R16(132), //
7442 B(Jump), U8(-118), //
7443 B(MovWide), R16(132), R16(125), //
7444 B(Ldar), R(125), //
7445 B(MovWide), R16(125), R16(132), //
7446 B(Return), //
7447 }},
7448 {"var x0 = 1234;\n"
7449 "var x1 = 0;\n"
7450 "for (x128 in x0) {"
7451 " x1 += x128;"
7452 "}"
7453 "return x1;\n",
7454 167 * kPointerSize,
7455 1,
7456 159,
7457 {
7458 B(LdaConstant), U8(0), //
7459 B(Star), R(0), //
7460 B(LdaZero), //
7461 B(Star), R(1), //
7462 B(Ldar), R(0), //
7463 B(JumpIfUndefinedConstant), U8(3), //
7464 B(JumpIfNullConstant), U8(2), //
7465 B(ToObject), //
7466 B(JumpIfNullConstant), U8(1), //
7467 B(MovWide), R16(161), R16(125), //
7468 B(Star), R(125), //
7469 B(MovWide), R16(125), R16(161), //
7470 B(ForInPrepareWide), R16(162), //
7471 B(LdaZero), //
7472 B(MovWide), R16(165), R16(125), //
7473 B(Star), R(125), //
7474 B(MovWide), R16(125), R16(165), //
7475 B(MovWide), R16(165), R16(125), //
7476 B(MovWide), R16(164), R16(126), //
7477 B(ForInDone), R(125), R(126), //
7478 B(MovWide), R16(126), R16(164), //
7479 B(MovWide), R16(125), R16(165), //
7480 B(JumpIfToBooleanTrue), U8(89), //
7481 B(ForInNextWide), R16(161), R16(165), R16(162), //
7482 B(JumpIfUndefined), U8(54), //
7483 B(MovWide), R16(132), R16(125), //
7484 B(Star), R(125), //
7485 B(MovWide), R16(125), R16(132), //
7486 B(Ldar), R(1), //
7487 B(MovWide), R16(166), R16(125), //
7488 B(Star), R(125), //
7489 B(MovWide), R16(125), R16(166), //
7490 B(MovWide), R16(132), R16(125), //
7491 B(Ldar), R(125), //
7492 B(MovWide), R16(125), R16(132), //
7493 B(MovWide), R16(166), R16(125), //
7494 B(Add), R(125), //
7495 B(MovWide), R16(125), R16(166), //
7496 B(Star), R(1), //
7497 B(MovWide), R16(165), R16(125), //
7498 B(ForInStep), R(125), //
7499 B(MovWide), R16(125), R16(165), //
7500 B(MovWide), R16(165), R16(125), //
7501 B(Star), R(125), //
7502 B(MovWide), R16(125), R16(165), //
7503 B(Jump), U8(-110), //
7504 B(Ldar), R(1), //
7505 B(Return), //
7506 },
7507 4,
7508 {1234, 142, 145, 147}},
7509 {"x0 = %Add(x64, x63);\n"
7510 "x1 = %Add(x27, x143);\n"
7511 "%TheHole();\n"
7512 "return x1;\n",
7513 163 * kPointerSize,
7514 1,
7515 90,
7516 {
7517 B(Ldar), R(64), //
7518 B(MovWide), R16(161), R16(125), //
7519 B(Star), R(125), //
7520 B(MovWide), R16(125), R16(161), //
7521 B(Ldar), R(63), //
7522 B(MovWide), R16(162), R16(125), //
7523 B(Star), R(125), //
7524 B(MovWide), R16(125), R16(162), //
7525 B(CallRuntimeWide), U16(Runtime::kAdd), R16(161), U8(2), //
7526 B(Star), R(0), //
7527 B(Ldar), R(27), //
7528 B(MovWide), R16(161), R16(125), //
7529 B(Star), R(125), //
7530 B(MovWide), R16(125), R16(161), //
7531 B(MovWide), R16(147), R16(125), //
7532 B(Ldar), R(125), //
7533 B(MovWide), R16(125), R16(147), //
7534 B(MovWide), R16(162), R16(125), //
7535 B(Star), R(125), //
7536 B(MovWide), R16(125), R16(162), //
7537 B(CallRuntimeWide), U16(Runtime::kAdd), R16(161), U8(2), //
7538 B(Star), R(1), //
7539 B(CallRuntime), U16(Runtime::kTheHole), R(0), U8(0), //
7540 B(Ldar), R(1), //
7541 B(Return), //
7542 }}};
7543
7544 for (size_t i = 0; i < arraysize(snippets); ++i) {
7545 std::string body = prologue + snippets[i].code_snippet;
7546 Handle<BytecodeArray> bytecode_array =
7547 helper.MakeBytecodeForFunctionBody(body.c_str());
7548 CheckBytecodeArrayEqual(snippets[i], bytecode_array);
7549 }
7550 }
7551
7285 } // namespace interpreter 7552 } // namespace interpreter
7286 } // namespace internal 7553 } // namespace internal
7287 } // namespace v8 7554 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/register-translator.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698