Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1613103002: command_buffer_gles2: Fix command-line arguments if they are passed (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sampler-binduniform-bug
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer_gles2: Fix command-line arguments if they are passed Set the command-line arguments correctly if they are passed with CHROME_COMMAND_BUFFER_GLES2_ARGS. Previously the first argument would go in the place of the app name. Also initialize the command-line on Windows. BUG=skia:2992 Committed: https://crrev.com/b01b354b22648b2d8c98efa2e5bde24915d77edb Cr-Commit-Position: refs/heads/master@{#370930}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : win compile fix #

Patch Set 4 : win2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M gpu/gles2_conform_support/egl/egl.cc View 1 2 3 2 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-21 12:41:03 UTC) #2
piman
lgtm
4 years, 11 months ago (2016-01-21 20:18:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613103002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613103002/2
4 years, 11 months ago (2016-01-22 06:42:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/162972)
4 years, 11 months ago (2016-01-22 07:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613103002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613103002/50001
4 years, 11 months ago (2016-01-22 09:06:02 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 11 months ago (2016-01-22 09:29:24 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b01b354b22648b2d8c98efa2e5bde24915d77edb Cr-Commit-Position: refs/heads/master@{#370930}
4 years, 11 months ago (2016-01-22 09:30:16 UTC) #15
Kimmo Kinnunen
4 years, 11 months ago (2016-01-22 11:17:54 UTC) #16
Message was sent while issue was closed.
Took the liberty to rearrange the code slightly to get windows version working,
and pushed the commit..

Powered by Google App Engine
This is Rietveld 408576698