Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 161303003: Add a version of WebApplicationCacheHost::willStartMainResourceRequest that doesn't depend on WebFr… (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add a version of WebApplicationCacheHost::willStartMainResourceRequest that doesn't depend on WebFrame This is in preparation for removing WebApplicationCacheHost's dependency public/web, allowing it to move to public/platform (and thus allow it to be referenced from core). BUG=343272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public/web/WebApplicationCacheHost.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
adamk
6 years, 10 months ago (2014-02-12 22:12:53 UTC) #1
adamk
See https://codereview.chromium.org/161573002/ for how the Chromium side will make use of this patch.
6 years, 10 months ago (2014-02-12 22:19:16 UTC) #2
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-12 22:20:05 UTC) #3
michaeln
lgtm2
6 years, 10 months ago (2014-02-12 22:24:50 UTC) #4
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-12 22:27:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161303003/1
6 years, 10 months ago (2014-02-12 22:28:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161303003/1
6 years, 10 months ago (2014-02-12 22:37:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161303003/1
6 years, 10 months ago (2014-02-12 22:38:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161303003/1
6 years, 10 months ago (2014-02-12 22:44:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/161303003/1
6 years, 10 months ago (2014-02-12 22:46:14 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 00:47:45 UTC) #11
Message was sent while issue was closed.
Change committed as 167055

Powered by Google App Engine
This is Rietveld 408576698