Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1612993003: [UMA] Track WebSocket usage (Closed)

Created:
4 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 10 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UMA] Track WebSocket usage BUG=none R=yhirano,isherman,mkwst Committed: https://crrev.com/56bbee3b4654e519b274a9cd3ca56918a6390d55 Cr-Commit-Position: refs/heads/master@{#371796}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Resolved UseCounter ID conflict #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
tyoshino (SeeGerritForStatus)
4 years, 11 months ago (2016-01-21 09:52:52 UTC) #3
yhirano
lgtm
4 years, 11 months ago (2016-01-25 01:42:42 UTC) #4
tyoshino (SeeGerritForStatus)
+isherman
4 years, 10 months ago (2016-01-25 05:47:13 UTC) #6
Ilya Sherman
histograms.xml lgtm
4 years, 10 months ago (2016-01-25 19:38:37 UTC) #7
tyoshino (SeeGerritForStatus)
+mkwst Mike, please review UseCounter.h
4 years, 10 months ago (2016-01-26 17:18:20 UTC) #9
Mike West
LGTM.
4 years, 10 months ago (2016-01-27 06:38:34 UTC) #11
tyoshino (SeeGerritForStatus)
bumped up the number to resolve conflict
4 years, 10 months ago (2016-01-27 06:44:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612993003/40001
4 years, 10 months ago (2016-01-27 06:44:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/165046)
4 years, 10 months ago (2016-01-27 08:58:02 UTC) #17
tyoshino (SeeGerritForStatus)
resolved conflict
4 years, 10 months ago (2016-01-27 09:59:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612993003/60001
4 years, 10 months ago (2016-01-27 10:00:30 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-01-27 16:20:39 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 16:21:32 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/56bbee3b4654e519b274a9cd3ca56918a6390d55
Cr-Commit-Position: refs/heads/master@{#371796}

Powered by Google App Engine
This is Rietveld 408576698