Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1612993002: Unflake dynamic adding of preload links test (Closed)

Created:
4 years, 11 months ago by Yoav Weiss
Modified:
4 years, 11 months ago
Reviewers:
Nate Chapin, acutter
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unflake dynamic adding of preload links test Move the dynamic addition of preload links test to use to onload event, as this is now supported, and would avoid using a flaky timeout. BUG=579854 Committed: https://crrev.com/6712b90179fa0cb79551d0cad2458dad4c85c37e Cr-Commit-Position: refs/heads/master@{#370754}

Patch Set 1 #

Patch Set 2 : Removed test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/dynamic_adding_preload.html View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yoav Weiss
4 years, 11 months ago (2016-01-21 10:00:05 UTC) #3
Nate Chapin
lgtm
4 years, 11 months ago (2016-01-21 18:58:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612993002/20001
4 years, 11 months ago (2016-01-21 19:30:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 19:41:34 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:43:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6712b90179fa0cb79551d0cad2458dad4c85c37e
Cr-Commit-Position: refs/heads/master@{#370754}

Powered by Google App Engine
This is Rietveld 408576698