Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1612943003: Shuts down input audio for long sequence of AudioUnitRender errors on Mac OSX (Closed)

Created:
4 years, 11 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shuts down input audio for long sequence of AudioUnitRender errors on Mac OSX BUG=549021 Committed: https://crrev.com/eb8a44dd73f93515b8ad6caaa3aceb8458ff8f5f Cr-Commit-Position: refs/heads/master@{#370708}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cleanup #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
henrika (OOO until Aug 14)
PTAL
4 years, 11 months ago (2016-01-21 15:03:35 UTC) #1
tommi (sloooow) - chröme
I think you don't need the extra include https://codereview.chromium.org/1612943003/diff/1/media/audio/mac/audio_low_latency_input_mac.cc File media/audio/mac/audio_low_latency_input_mac.cc (right): https://codereview.chromium.org/1612943003/diff/1/media/audio/mac/audio_low_latency_input_mac.cc#newcode604 media/audio/mac/audio_low_latency_input_mac.cc:604: std::string ...
4 years, 11 months ago (2016-01-21 15:09:20 UTC) #4
henrika (OOO until Aug 14)
PTAL
4 years, 11 months ago (2016-01-21 15:21:30 UTC) #5
tommi (sloooow) - chröme
lgtm
4 years, 11 months ago (2016-01-21 15:42:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612943003/40001
4 years, 11 months ago (2016-01-21 15:46:17 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-21 16:09:06 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 16:10:01 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/eb8a44dd73f93515b8ad6caaa3aceb8458ff8f5f
Cr-Commit-Position: refs/heads/master@{#370708}

Powered by Google App Engine
This is Rietveld 408576698