Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1612933006: Moved the AST related tests to their new locations (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1409 lines, -5352 lines) Patch
A pkg/analyzer/test/dart/ast/ast_test.dart View 1 chunk +1308 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/dart/ast/test_all.dart View 1 chunk +6 lines, -4 lines 0 comments Download
A pkg/analyzer/test/dart/ast/visitor_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
M pkg/analyzer/test/dart/element/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/dart/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/enum_test.dart View 3 chunks +0 lines, -13 lines 0 comments Download
D pkg/analyzer/test/generated/ast_test.dart View 1 chunk +0 lines, -3993 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A + pkg/analyzer/test/src/dart/ast/test_all.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analyzer/test/src/dart/ast/utilities_test.dart View 5 chunks +5 lines, -1331 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/element/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Test locations now correspond to the location of the class under test (for AST-related classes).
4 years, 11 months ago (2016-01-23 01:24:01 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-23 01:50:31 UTC) #3
Brian Wilkerson
4 years, 11 months ago (2016-01-23 17:45:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd0c42cb72a4c218e4b04890f0ef666c6f6c0eb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698