Add test case for updating the bounds of snapped window.

ash/wm/workspace/workspace_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_layout_manager.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/session_state_delegate.h"
@@ skipping 98 matching lines @@
 }
 
 void WorkspaceLayoutManager::SetShelf(internal::ShelfLayoutManager* shelf) {
   shelf_ = shelf;
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // WorkspaceLayoutManager, aura::LayoutManager implementation:
 
 void WorkspaceLayoutManager::OnWindowAddedToLayout(Window* child) {
-  AdjustWindowBoundsWhenAdded(wm::GetWindowState(child));
+  wm::WindowState* window_state = wm::GetWindowState(child);
+  AdjustWindowBoundsWhenAdded(window_state);
 
   windows_.insert(child);
   child->AddObserver(this);
-  wm::WindowState* window_state = wm::GetWindowState(child);
   window_state->AddObserver(this);

[pkotwicz, 2014/02/13 00:32:39]

Isn't the logic below redundant and already performed in
AdjustWindowBoundsWhenAdded(window_state)

[oshima, 2014/02/13 01:10:13]

Good point. Looks like we've been doing this twice. Removed.

-
-  // Only update the bounds if the window has a show state that depends on the
-  // workspace area.
-  if (window_state->IsMaximized()) {
-    SetChildBoundsDirect(
-        child, ScreenUtil::GetMaximizedWindowBoundsInParent(child));
-  } else if (window_state->IsFullscreen()) {
-    SetChildBoundsDirect(
-        child, ScreenUtil::GetDisplayBoundsInParent(child));
-  }
+  if (!window_state->is_dragged())
+    SetMaximizedOrFullscreenBounds(window_state);
 
   UpdateShelfVisibility();
   UpdateFullscreenState();
   WindowPositioner::RearrangeVisibleWindowOnShow(child);
 }
 
 void WorkspaceLayoutManager::OnWillRemoveWindowFromLayout(Window* child) {
   windows_.erase(child);
   child->RemoveObserver(this);
   wm::GetWindowState(child)->RemoveObserver(this);
@@ skipping 23 matching lines @@
   }
   UpdateShelfVisibility();
 }
 
 void WorkspaceLayoutManager::SetChildBounds(
     Window* child,
     const gfx::Rect& requested_bounds) {
   wm::WindowState* window_state = wm::GetWindowState(child);
   if (window_state->is_dragged()) {
     SetChildBoundsDirect(child, requested_bounds);
+  } else if (window_state->IsSnapped()) {

[pkotwicz, 2014/02/13 00:32:39]

This allows a snapped window to be as wide as it wants, notably several x times
the width of the workarea?

[oshima, 2014/02/13 01:10:13]

Fixed. I think the same thing can happen during drag (JS may set bounds during
drag), but I'll address that later.

+    gfx::Rect child_bounds(requested_bounds);
+    AdjustSnappedBounds(window_state, &child_bounds);
+    SetChildBoundsDirect(child, child_bounds);
   } else if (!SetMaximizedOrFullscreenBounds(window_state)) {
     // Some windows rely on this to set their initial bounds.
     // Non-maximized/full-screen windows have their size constrained to the
     // work-area.
     gfx::Rect child_bounds(requested_bounds);
     child_bounds.set_width(std::min(work_area_in_parent_.width(),
                                     child_bounds.width()));
     child_bounds.set_height(std::min(work_area_in_parent_.height(),
                                      child_bounds.height()));
-    AdjustSnappedBounds(window_state, &child_bounds);
     SetChildBoundsDirect(child, child_bounds);
   }
   UpdateShelfVisibility();
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // WorkspaceLayoutManager, ash::ShellObserver implementation:
 
 void WorkspaceLayoutManager::OnDisplayWorkAreaInsetsChanged() {
   const gfx::Rect work_area(ScreenUtil::ConvertRectFromScreen(
@@ skipping 335 matching lines @@
   ui::ScopedLayerAnimationSettings slide_settings(layer->GetAnimator());
   slide_settings.SetPreemptionStrategy(
       ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
   slide_settings.SetTransitionDuration(
       base::TimeDelta::FromMilliseconds(kBoundsChangeSlideDurationMs));
   SetChildBoundsDirect(child, bounds);
 }
 
 }  // namespace internal
 }  // namespace ash