mac: Allows extensions to hide the bookmark page menu item.

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/prefs/pref_service.h"
@@ skipping 194 matching lines @@
         break;
       }
       case chrome::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC: {
         std::pair<const std::string, gfx::NativeWindow>* payload =
             content::Details<std::pair<const std::string, gfx::NativeWindow> >(
                 details).ptr();
         std::string extension_id = payload->first;
         gfx::NativeWindow window = payload->second;
         if (window != browser_->window()->GetNativeWindow())
           break;
-        ExtensionService* service = browser_->profile()->GetExtensionService();
-        if (!service)
-          break;
-        const Extension* extension = service->GetExtensionById(extension_id,
-                                                               false);
-        if (!extension)
-          break;
-        BrowserActionButton* button = [owner_ buttonForExtension:extension];
-        // |button| can be nil when the browser action has its button hidden.
-        if (button)
-          [owner_ browserActionClicked:button];
+        [owner_ activateBrowserAction:extension_id];
         break;
       }
       default:
         NOTREACHED() << L"Unexpected notification";
     }
   }
 
   // ExtensionToolbarModel::Observer implementation.
   virtual void BrowserActionAdded(
       const Extension* extension,
@@ skipping 209 matching lines @@
   if (effect == NSViewAnimationFadeInEffect) {
     return NO;
   } else if (effect == NSViewAnimationFadeOutEffect) {
     return YES;
   }
 
   NOTREACHED();
   return YES;
 }
 
+- (void)activateBrowserAction:(const std::string&)extension_id {
+  ExtensionService* service = browser_->profile()->GetExtensionService();
+  if (!service)
+    return;
+
+  const Extension* extension = service->GetExtensionById(extension_id, false);
+  if (!extension)
+    return;
+
+  BrowserActionButton* button = [self buttonForExtension:extension];
+  // |button| can be nil when the browser action has its button hidden.
+  if (button)
+    [self browserActionClicked:button];
+}
+
 #pragma mark -
 #pragma mark NSMenuDelegate
 
 - (void)menuNeedsUpdate:(NSMenu*)menu {
   [menu removeAllItems];
 
   // See menu_button.h for documentation on why this is needed.
   [menu addItemWithTitle:@"" action:nil keyEquivalent:@""];
 
   for (BrowserActionButton* button in hiddenButtons_.get()) {
@@ skipping 417 matching lines @@
   const extensions::ExtensionList& toolbar_items =
       toolbarModel_->toolbar_items();
   if (index < toolbar_items.size()) {
     const Extension* extension = toolbar_items[index].get();
     return [buttons_ objectForKey:base::SysUTF8ToNSString(extension->id())];
   }
   return nil;
 }
 
 @end