Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 161293002: mac: Allows extensions to hide the bookmark page menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make sure changes only apply to OSX. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 5 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/mac/mac_util.h" 10 #include "base/mac/mac_util.h"
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 // gets enlarged by H. 751 // gets enlarged by H.
752 // I believe these "automatic" resizing are caused by setAutoresizingMask of 752 // I believe these "automatic" resizing are caused by setAutoresizingMask of
753 // of the cocoa view in WebContentsViewMac, which defeats the purpose of 753 // of the cocoa view in WebContentsViewMac, which defeats the purpose of
754 // WebContentsDelegate::GetSizeForNewRenderView i.e. to prevent resizing of 754 // WebContentsDelegate::GetSizeForNewRenderView i.e. to prevent resizing of
755 // RenderWidgetHostView in (2) and (3). 755 // RenderWidgetHostView in (2) and (3).
756 return 0; 756 return 0;
757 } 757 }
758 758
759 void BrowserWindowCocoa::ShowPageActionPopup( 759 void BrowserWindowCocoa::ShowPageActionPopup(
760 const extensions::Extension* extension) { 760 const extensions::Extension* extension) {
761 NOTIMPLEMENTED(); 761 [cocoa_controller() activatePageAction:extension->id()];
762 } 762 }
763 763
764 void BrowserWindowCocoa::ShowBrowserActionPopup( 764 void BrowserWindowCocoa::ShowBrowserActionPopup(
765 const extensions::Extension* extension) { 765 const extensions::Extension* extension) {
766 NOTIMPLEMENTED(); 766 [cocoa_controller() activateBrowserAction:extension->id()];
767 } 767 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_utils.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698