chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 161293002: mac: Allows extensions to hide the bookmark page menu item.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 161293002: mac: Allows extensions to hide the bookmark page menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to remaining rsesek/wittman comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/bookmarks/bookmark_utils.cc ('K') | « chrome/browser/ui/bookmarks/bookmark_utils.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_

6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_	6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_

7	7

8 #include "base/mac/scoped_nsobject.h"	8 #include "base/mac/scoped_nsobject.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "chrome/browser/bookmarks/bookmark_model.h"	10 #include "chrome/browser/bookmarks/bookmark_model.h"

	11 #include "chrome/browser/extensions/api/commands/command_service.h"
	Mike Wittman 2014/02/26 20:16:03 Remove this header? Remove this header? erikchen 2014/02/26 20:53:52 Done. Show quoted text On 2014/02/26 20:16:03, Mike Wittman wrote: > Remove this header? Done.
11 #include "chrome/browser/extensions/extension_keybinding_registry.h"	12 #include "chrome/browser/extensions/extension_keybinding_registry.h"

12 #include "chrome/browser/ui/browser_window.h"	13 #include "chrome/browser/ui/browser_window.h"

13 #include "chrome/browser/ui/search/search_model_observer.h"	14 #include "chrome/browser/ui/search/search_model_observer.h"

14 #include "ui/base/ui_base_types.h"	15 #include "ui/base/ui_base_types.h"

15	16

16 class Browser;	17 class Browser;

17 @class BrowserWindowController;	18 @class BrowserWindowController;

18 @class FindBarCocoaController;	19 @class FindBarCocoaController;

19 @class NSEvent;	20 @class NSEvent;

20 @class NSMenu;	21 @class NSMenu;

(...skipping 158 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
179 NSWindow* window() const; // Accessor for the (current) \|NSWindow\|.	180 NSWindow* window() const; // Accessor for the (current) \|NSWindow\|.

180	181

181 Browser* browser_; // weak, owned by controller	182 Browser* browser_; // weak, owned by controller

182 BrowserWindowController* controller_; // weak, owns us	183 BrowserWindowController* controller_; // weak, owns us

183 base::scoped_nsobject<NSString> pending_window_title_;	184 base::scoped_nsobject<NSString> pending_window_title_;

184 ui::WindowShowState initial_show_state_;	185 ui::WindowShowState initial_show_state_;

185 NSInteger attention_request_id_; // identifier from requestUserAttention	186 NSInteger attention_request_id_; // identifier from requestUserAttention

186 };	187 };

187	188

188 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_	189 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_

OLD	NEW