mac: Allows extensions to hide the bookmark page menu item.

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
@@ skipping 33 matching lines @@
 #import "chrome/browser/ui/cocoa/web_dialog_window_controller.h"
 #import "chrome/browser/ui/cocoa/website_settings_bubble_controller.h"
 #include "chrome/browser/ui/search/search_model.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/autofill/core/common/password_form.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/gfx/rect.h"
 
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
 #import "chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h"
@@ skipping 685 matching lines @@
   // A.height() + H and RenderWidgetHostView's height becomes A.height() + 2H.
   // Strangely, the RenderWidgetHostView for the previous navigation entry also
   // gets enlarged by H.
   // I believe these "automatic" resizing are caused by setAutoresizingMask of
   // of the cocoa view in WebContentsViewMac, which defeats the purpose of
   // WebContentsDelegate::GetSizeForNewRenderView i.e. to prevent resizing of
   // RenderWidgetHostView in (2) and (3).
   return 0;
 }
 
+void BrowserWindowCocoa::ShowExtensionActionPopup(
+    extensions::CommandService::ExtensionCommandType type,
+    std::string extension_id) {
+  // Set the notification type.
+  int notification_type;

[Robert Sesek, 2014/02/26 18:05:13]

Initialize this since you do not have a default: case.

[erikchen, 2014/02/26 19:58:23]

method was removed.

On 2014/02/26 18:05:13, rsesek wrote:

+  switch (type) {
+    case extensions::CommandService::NAMED:
+      NOTREACHED();
+      return;
+    case extensions::CommandService::BROWSER_ACTION:
+      notification_type =
+          chrome::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC;
+      break;
+    case extensions::CommandService::PAGE_ACTION:
+      notification_type =
+          chrome::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC;
+      break;
+  }
+  // Dispatch a notification, which triggers the popup.
+  std::pair<const std::string, gfx::NativeWindow> details =
+      std::make_pair(extension_id, window());
+  content::NotificationService::current()->Notify(

[Robert Sesek, 2014/02/26 18:05:13]

There's an active effort to remove notifications from Chrome. Is there a
non-notification way to do this?

[erikchen, 2014/02/26 19:58:23]

certainly. I've plumbed through the necessary logic for showing page/browser
actions directly, rather than through a notification system.

On 2014/02/26 18:05:13, rsesek wrote:

+      notification_type,
+      content::Source<Profile>(browser_->profile()),
+      content::Details<std::pair<const std::string, gfx::NativeWindow> >(
+          &details));
+}
+
 void BrowserWindowCocoa::ShowPageActionPopup(
     const extensions::Extension* extension) {
-  NOTIMPLEMENTED();
+  ShowExtensionActionPopup(extensions::CommandService::PAGE_ACTION,
+                           extension->id());
 }
 
 void BrowserWindowCocoa::ShowBrowserActionPopup(
     const extensions::Extension* extension) {
-  NOTIMPLEMENTED();
+  ShowExtensionActionPopup(extensions::CommandService::BROWSER_ACTION,
+                           extension->id());
 }