Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1612923003: Revert "Revert of [turbofan] optimize spills in defered blocks (patchset #3 id:240001 of https://co… (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [turbofan] optimize spills in defered blocks (patchset #3 id:240001 of https://codereview.chromium.org/1551013002/ )" This reverts commit 7f62e1222df37e0fcbe96d550a1fdcd3499ba37c. The regressions reported in the bug below appear to be bogus, and caused by chromium:579503 BUG=chromium:579900 LOG=N Committed: https://crrev.com/17ea41bad498d24934c94834f2695d1f58b88ffb Cr-Commit-Position: refs/heads/master@{#33454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -220 lines) Patch
M src/compiler/live-range-separator.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/register-allocator.h View 6 chunks +29 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.cc View 11 chunks +267 lines, -214 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-21 18:00:13 UTC) #3
Jarin
lgtm
4 years, 11 months ago (2016-01-22 05:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612923003/1
4 years, 11 months ago (2016-01-22 05:52:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10038)
4 years, 11 months ago (2016-01-22 05:54:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612923003/1
4 years, 11 months ago (2016-01-22 06:00:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 06:26:34 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 06:27:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17ea41bad498d24934c94834f2695d1f58b88ffb
Cr-Commit-Position: refs/heads/master@{#33454}

Powered by Google App Engine
This is Rietveld 408576698