Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1612913002: Remove Oilpan TODO from SampledEffect (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Oilpan TODO from SampledEffect SampledEffect cannot be made non-Finalized due to the Vector<RefPtr<Interpolation>> member requiring destruction. This change removes the TODO to make SampledEffect non-Finalized. Committed: https://crrev.com/57a139b5aaf9aee0db4b288dd0834845f5a999af Cr-Commit-Position: refs/heads/master@{#370645}

Patch Set 1 #

Patch Set 2 : Remove comment only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/animation/SampledEffect.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alancutter (OOO until 2018)
4 years, 11 months ago (2016-01-21 05:44:07 UTC) #2
sof
lgtm
4 years, 11 months ago (2016-01-21 06:06:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612913002/20001
4 years, 11 months ago (2016-01-21 06:12:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 07:38:03 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/57a139b5aaf9aee0db4b288dd0834845f5a999af Cr-Commit-Position: refs/heads/master@{#370645}
4 years, 11 months ago (2016-01-21 07:38:44 UTC) #11
haraken
4 years, 11 months ago (2016-01-21 09:42:38 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698