Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1612893002: Re-add re-named typed CSS OM tests. (Closed)

Created:
4 years, 11 months ago by meade_UTC10
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews, rjwright, tridgell, lawton
Base URL:
https://chromium.googlesource.com/chromium/src.git@deletetests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add re-named typed CSS OM tests. They were deleted in https://codereview.chromium.org/1618523002 because apparently some filesystems get confused by only changing the case of characters in the filename, so I'm re-adding them in this CL. Committed: https://crrev.com/c858541bed56840fbab83ed5476652a00c2f8e90 Cr-Commit-Position: refs/heads/master@{#370640}

Patch Set 1 #

Patch Set 2 : make sure most up to date versions are used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/typedcssom/calcLength.html View 1 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/lengthValue.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/numberValue.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/scaleTransformComponent.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/simpleLength.html View 1 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/transformValue.html View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
meade_UTC10
4 years, 11 months ago (2016-01-21 04:41:41 UTC) #2
alancutter (OOO until 2018)
lgtm with nits. Subject should mention the rename. In the description it mentions a followup ...
4 years, 11 months ago (2016-01-21 04:44:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612893002/20001
4 years, 11 months ago (2016-01-21 05:55:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 06:50:12 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:51:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c858541bed56840fbab83ed5476652a00c2f8e90
Cr-Commit-Position: refs/heads/master@{#370640}

Powered by Google App Engine
This is Rietveld 408576698