Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1612863004: Revert of [third-party] Netty fork of Tomcat Native (Closed)

Created:
4 years, 11 months ago by kapishnikov
Modified:
4 years, 11 months ago
Reviewers:
rsleevi, mef, davidben, xunjieli, pauljensen, agl
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [third-party] Netty fork of Tomcat Native (patchset #12 id:210001 of https://codereview.chromium.org/1537473002/ ) Reason for revert: error on the clank-tot bot: https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/17864/steps/compile/logs/stdio Original issue's description: > [third-party] Netty Server and dependencies > > Added new libraries to the Chromium third-party library collection: > 1. Netty 4 Server. See http://netty.io > 2. Netty fork of Tomcat Native (netty-tcnative). See http://netty.io/wiki/forked-tomcat-native.html > and the library tc-native depends on: > 3. 'Apache Portable Runtime'. See http://apr.apache.org > > The server provides support for Http/2 protocol, which is needed for testing some of the Cronet features > on Android, in particular, the new Bidirectional Streaming API. > > To build the netty-tcnative library call: > ninja -C out/Debug netty-tcnative > > The output files can be found here: > - out/Debug/lib/libnetty-tcnative.so > - out/Debug/lib.java/netty-tcnative.jar > > BUG=563732 > > Committed: https://crrev.com/6dd98af3db0b8e809ed95ff66620181efbf3f8f1 > Cr-Commit-Position: refs/heads/master@{#370791} TBR=xunjieli@chromium.org,pauljensen@chromium.org,mef@chromium.org,rsleevi@chrium.org,agl@chromium.org,davidben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563732 Committed: https://crrev.com/e3846643362504ec3dcb104db448fc94eaaee623 Cr-Commit-Position: refs/heads/master@{#370815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1372 lines) Patch
M .gitignore View 2 chunks +0 lines, -3 lines 0 comments Download
M DEPS View 3 chunks +1 line, -10 lines 0 comments Download
M components/cronet.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/apache-portable-runtime/LICENSE View 1 chunk +0 lines, -294 lines 0 comments Download
D third_party/apache-portable-runtime/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/apache-portable-runtime/README.chromium View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/apache-portable-runtime/apr.gyp View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/apache-portable-runtime/diff.patch View 1 chunk +0 lines, -234 lines 0 comments Download
D third_party/netty-tcnative/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/netty-tcnative/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/netty-tcnative/README.chromium View 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/netty-tcnative/netty-tcnative.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/netty4/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/netty4/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/netty4/README.chromium View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/netty4/netty.gyp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
kapishnikov
Created Revert of [third-party] Netty fork of Tomcat Native
4 years, 11 months ago (2016-01-21 22:04:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612863004/1
4 years, 11 months ago (2016-01-21 22:05:43 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-21 22:05:44 UTC) #4
agl
lgtm
4 years, 11 months ago (2016-01-21 22:06:30 UTC) #5
agl
lgtm
4 years, 11 months ago (2016-01-21 22:06:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612863004/1
4 years, 11 months ago (2016-01-21 23:10:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 23:13:04 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 23:13:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3846643362504ec3dcb104db448fc94eaaee623
Cr-Commit-Position: refs/heads/master@{#370815}

Powered by Google App Engine
This is Rietveld 408576698