src/typing.cc - Issue 16128004: Reorder switch clauses using newly-introduced execution counters in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 16128004: Reorder switch clauses using newly-introduced execution counters in (Closed) Base URL: gh:v8/v8.git@master

Patch Set: tweak heuristic Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index c2d418fab991963b05a636283692d6154c3d3027..f187605f0458c2e02ecdecc8518782faf4983c29 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -167,7 +167,8 @@ void AstTyper::VisitSwitchStatement(SwitchStatement* stmt) {

stmt->set_switch_type(switch_type);

// TODO(rossberg): can we eliminate this special case and extra loop?

- if (switch_type == SwitchStatement::SMI_SWITCH) {

+ if (switch_type == SwitchStatement::SMI_SWITCH ||

+ switch_type == SwitchStatement::STRING_SWITCH) {

for (int i = 0; i < clauses->length(); ++i) {

CaseClause* clause = clauses->at(i);

if (!clause->is_default())

« no previous file with comments | « src/type-info.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »