Issue 1612773002: Avoid using wrong 'adaptor' for native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1612773002: Avoid using wrong 'adaptor' for native methods. (Closed)

Created:
4 years, 11 months ago by sra1

Modified:
4 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid using wrong 'adaptor' for native methods. The Dart arity adaptor was adding default arguments to the call instead of calling with the given number of arguments. The best way to fix this is to implement Issue 25548. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ffa96cdeac480db89c047f6664520d260cace059

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/inline.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download
	M	tests/html/html.status	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 11 months ago (2016-01-21 16:44:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ffa96cdeac480db89c047f6664520d260cace059 (presubmit successful).