Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1612753002:
Stop testing builds with runtime-detected NEON (Closed)
DescriptionStop testing builds with runtime-detected NEON
O frabjous day!
Chrome has switched on requiring NEON globally at head.
Android has always built with NEON as appropriate for each device.
In practice, this switches our Nexus 5 bots from runtime-detected to
building with NEON globally. It also lines a few columns up and makes
equivalent aliases more obviously the same.
We still have Build bots to test we can build on ARMv7 with no NEON. (We even have Build bots to test building ARMv6.)
(It looks like that buildbot_spec.json just hasn't been updated in a while.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612753002
CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/80fc19cd3a325aa3f397e55259b9f7d1f139ea37
Patch Set 1 #
Total comments: 3
Patch Set 2 : sort #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up. BUG=skia: ========== to ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + borenet@google.com, reed@google.com
Mike for the good-idea-in-general, Eric for the how-it's-done.
Description was changed from ========== Stop testing builds with runtime-detected NEON Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop testing builds with runtime-detected NEON O frabjous day! Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612753002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot on client.skia.android (JOB_TIMED_OUT, no build URL)
Code change LGTM https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.json File tools/buildbot_spec.json (right): https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.json#ne... tools/buildbot_spec.json:1: { Ignoring diffs in this file since it seems not to have been kept in sync. https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.py#newc... tools/buildbot_spec.py:227: 'NexusPlayer': 'x86', Nit: can we make these alphabetical?
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.py File tools/buildbot_spec.py (right): https://codereview.chromium.org/1612753002/diff/1/tools/buildbot_spec.py#newc... tools/buildbot_spec.py:227: 'NexusPlayer': 'x86', On 2016/01/21 12:40:30, borenet wrote: > Nit: can we make these alphabetical? Done.
Description was changed from ========== Stop testing builds with runtime-detected NEON O frabjous day! Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot ========== to ========== Stop testing builds with runtime-detected NEON O frabjous day! Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. We still have Build bots to test we can build on ARMv7 with no NEON. (We even have Build bots to test building ARMv6.) (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot ==========
The CQ bit was checked by mtklein@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com Link to the patchset: https://codereview.chromium.org/1612753002/#ps20001 (title: "sort")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612753002/20001
Message was sent while issue was closed.
Description was changed from ========== Stop testing builds with runtime-detected NEON O frabjous day! Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. We still have Build bots to test we can build on ARMv7 with no NEON. (We even have Build bots to test building ARMv6.) (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot ========== to ========== Stop testing builds with runtime-detected NEON O frabjous day! Chrome has switched on requiring NEON globally at head. Android has always built with NEON as appropriate for each device. In practice, this switches our Nexus 5 bots from runtime-detected to building with NEON globally. It also lines a few columns up and makes equivalent aliases more obviously the same. We still have Build bots to test we can build on ARMv7 with no NEON. (We even have Build bots to test building ARMv6.) (It looks like that buildbot_spec.json just hasn't been updated in a while.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/80fc19cd3a325aa3f397e55259b9f7d1f139ea37 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/80fc19cd3a325aa3f397e55259b9f7d1f139ea37 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
