Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: components/crash/content/app/crashpad_win.cc

Issue 1612663002: Use a valid /prefetch argument when launching a process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bit
Patch Set: self-review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 1628ab6a9d5cbfc1f8945e24cdee952fea8f4a2c..b3a4e97dd6f69baae9b1bc735746c6ad9004f260 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -84,6 +84,10 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
exe_file = exe_dir.Append(FILE_PATH_LITERAL("crashpad_handler.exe"));
} else {
arguments.push_back("--type=crashpad-handler");
+
+ // Add a prefetch argument to avoid polluting the prefetch profile of the
+ // browser process.
+ arguments.push_back("/prefetch:8");
gab 2016/01/26 21:40:26 I hate having to use hardcoded strings, why can't
fdoray 2016/01/27 20:12:19 Done. I was scared of adding the crashpad->content
fdoray 2016/01/28 22:11:06 Unfortunately, I can't use the constant here. - Th
}
// TODO(scottmg): See https://crashpad.chromium.org/bug/23.

Powered by Google App Engine
This is Rietveld 408576698