Use a valid /prefetch argument when launching a process.

chrome/app/chrome_exe_main_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <malloc.h>
 #include <shellscalingapi.h>
 #include <stddef.h>
 #include <tchar.h>
 
 #include <algorithm>
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/win/windows_version.h"
 #include "chrome/app/chrome_crash_reporter_client.h"
 #include "chrome/app/main_dll_loader_win.h"
+#include "chrome/app/prefetch_argument_win.h"
 #include "chrome/browser/chrome_process_finder_win.h"
 #include "chrome/browser/policy/policy_path_parser.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/installer/util/browser_distribution.h"
 #include "chrome_elf/chrome_elf_main.h"
 #include "components/crash/content/app/crash_reporter_client.h"
 #include "components/crash/content/app/crashpad.h"
 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
+#include "components/startup_metric_utils/common/pre_read_field_trial_utils_win.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
 #include "third_party/crashpad/crashpad/handler/handler_main.h"
 #include "ui/gfx/win/dpi.h"
 
 namespace {
 
 base::LazyInstance<ChromeCrashReporterClient>::Leaky g_chrome_crash_client =
     LAZY_INSTANCE_INITIALIZER;
 
@@ skipping 102 matching lines @@
   argv.erase(std::remove_if(argv.begin(), argv.end(),
                             [&process_type](const base::string16& str) {
                               return str.compare(0, process_type.size(),
                                                  process_type) == 0;
                             }),
              argv.end());
 
   scoped_ptr<char* []> argv_as_utf8(new char*[argv.size() + 1]);
   std::vector<std::string> storage;
   storage.reserve(argv.size());
+
+  size_t arg_append_index = 0;
   for (size_t i = 0; i < argv.size(); ++i) {
+    // Remove the /prefetch:# argument as it is not supported by Crashpad.
+    if (base::StartsWith(argv[i], L"/prefetch:", base::CompareCase::SENSITIVE))
+      continue;
+
     storage.push_back(base::UTF16ToUTF8(argv[i]));
-    argv_as_utf8[i] = &storage[i][0];
+    argv_as_utf8[arg_append_index] = &storage[arg_append_index][0];
+    ++arg_append_index;
   }
-  argv_as_utf8[argv.size()] = nullptr;
-  return crashpad::HandlerMain(static_cast<int>(argv.size()),
+  argv_as_utf8[arg_append_index] = nullptr;
+
+  return crashpad::HandlerMain(static_cast<int>(storage.size()),
                                argv_as_utf8.get());
 }
 
 }  // namespace
 
 // This helper is looked up in the browser to retrieve the crash reports. See
 // CrashUploadListCrashpad. Note that we do not pass an std::vector here,
 // because we do not want to allocate/free in different modules. The returned
 // pointer is read-only.
 extern "C" __declspec(dllexport) void GetUploadedReportsImpl(
     const crash_reporter::UploadedReport** reports,
     size_t* report_count) {
   crash_reporter::GetUploadedReports(g_uploaded_reports.Pointer());
   *reports = g_uploaded_reports.Pointer()->data();
   *report_count = g_uploaded_reports.Pointer()->size();
 }
 
 #if !defined(WIN_CONSOLE_APP)
 int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev, wchar_t*, int) {
 #else
 int main() {
   HINSTANCE instance = GetModuleHandle(nullptr);
 #endif
   // Initialize the CommandLine singleton from the environment.
   base::CommandLine::Init(0, nullptr);
+  const base::CommandLine* command_line =
+      base::CommandLine::ForCurrentProcess();
 
-  std::string process_type =
-      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
-          switches::kProcessType);
+  const std::string process_type =
+      command_line->GetSwitchValueASCII(switches::kProcessType);
+
+  startup_metric_utils::InitializePreReadOptions(
+      BrowserDistribution::GetDistribution()->GetRegistryPath());
+
+  // Confirm that an explicit prefetch profile is used for all process types
+  // except for the browser process. Any new process type will have to assign
+  // itself a prefetch id (see kPrefetchArgument* constants in
+  // content_switches.cc).

[gab, 2016/01/29 12:46:25]

s/)/ for details)/

[fdoray, 2016/01/29 15:33:30]

Done.

+  DCHECK(!startup_metric_utils::GetPreReadOptions().use_prefetch_argument ||
+         process_type.empty() ||
+         HasValidWindowsPrefetchArgument(*command_line));
 
   if (process_type == switches::kCrashpadHandler)
     return RunAsCrashpadHandler(*base::CommandLine::ForCurrentProcess());
 
   crash_reporter::SetCrashReporterClient(g_chrome_crash_client.Pointer());
   crash_reporter::InitializeCrashpad(process_type.empty(), process_type);
 
   SwitchToLFHeap();
 
   startup_metric_utils::RecordExeMainEntryPointTime(base::Time::Now());
 
   // Signal Chrome Elf that Chrome has begun to start.
   SignalChromeElf();
 
   // The exit manager is in charge of calling the dtors of singletons.
   base::AtExitManager exit_manager;
 
   // We don't want to set DPI awareness on pre-Win7 because we don't support
   // DirectWrite there. GDI fonts are kerned very badly, so better to leave
   // DPI-unaware and at effective 1.0. See also ShouldUseDirectWrite().
   if (base::win::GetVersion() >= base::win::VERSION_WIN7)
     EnableHighDPISupport();
 
-  if (AttemptFastNotify(*base::CommandLine::ForCurrentProcess()))
+  if (AttemptFastNotify(*command_line))
     return 0;
 
   // Load and launch the chrome dll. *Everything* happens inside.
   VLOG(1) << "About to load main DLL.";
   MainDllLoader* loader = MakeMainDllLoader();
   int rc = loader->Launch(instance);
   loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded();
   delete loader;
   return rc;
 }