content/public/common/DEPS - Issue 1612663002: Use a valid /prefetch argument when launching a process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/DEPS

Issue 1612663002: Use a valid /prefetch argument when launching a process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bit

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/ppapi_plugin_process_host.cc ('K') | « content/public/common/BUILD.gn ('k') | content/public/common/prefetch_argument_win.h » ('j') | content/public/common/prefetch_argument_win.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 specific_include_rules = {	1 specific_include_rules = {

2 ".*\.cc": [	2 ".*\.cc": [

3 "+content/common",	3 "+content/common",

4 ],	4 ],

5 "media_stream_request.h": [	5 "media_stream_request.h": [

6 "+media/audio/audio_parameters.h",	6 "+media/audio/audio_parameters.h",

7 ]	7 ],

	8 "prefetch_argument_win.cc": [

	9 # TODO(fdoray): Remove this once the PreRead field trial expires.

	10 # crbug.com/577698

	11 "+components/startup_metric_utils/common/pre_read_field_trial_utils_win.h"
	jam 2016/01/20 23:17:36 content shouldn't depend on this component, even t content shouldn't depend on this component, even temporarily. fdoray 2016/01/21 01:39:51 Could I add the /prefetch argument in ChromeConten Show quoted text On 2016/01/20 23:17:36, jam wrote: > content shouldn't depend on this component, even temporarily. > Could I add the /prefetch argument in ChromeContentBrowserClient::AppendExtraCommandLineSwitches to avoid changing content/? I tried to do this in another CL [1], but I was told that: - This shouldn't be in done chrome/, as all users of content/ should be able to benefit from this optimization. - It is better to set a prefetch id at the time a command line is created than to inspect an existing command line to determine which prefetch id to use [2]. Note: content already depends on this component startup_metric_utils_common. This component allows us to read the PreRead field trial options from the registry. The options are stored in the registry because they are needed before variations are read from the disk [4]. If we read the options from the registry in some cases and from variations::GetVariationParamValue in other cases, we could end up using different sets of options in the same process... [1] https://codereview.chromium.org/1595633002/diff/60001/chrome/browser/chrome_c... [2] https://codereview.chromium.org/1595633002/diff/20001/chrome/common/prefetch_... [3] https://code.google.com/p/chromium/codesearch#chromium/src/content/content_re... [4] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/main_dl...
	12 ],

8 }	13 }

OLD	NEW