Use stack locations instead of register for binary Smi operations when possible.

runtime/vm/assembler_ia32_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 322 matching lines @@
 ASSEMBLER_TEST_RUN(MoveExtendMemory, test) {
   typedef int (*MoveExtendMemory)();
   EXPECT_EQ(0xff - 1 + 0xffff,
             reinterpret_cast<MoveExtendMemory>(test->entry())());
 }
 
 
 ASSEMBLER_TEST_GENERATE(Bitwise, assembler) {
   __ movl(ECX, Immediate(42));
   __ xorl(ECX, ECX);
-  __ orl(ECX, Immediate(256));
-  __ movl(EAX, Immediate(4));
-  __ orl(ECX, EAX);
+  __ orl(ECX, Immediate(0x100));
+  __ movl(EAX, Immediate(0x648));
+  __ orl(ECX, EAX);  // 0x748.
   __ movl(EAX, Immediate(0xfff0));
-  __ andl(ECX, EAX);
+  __ andl(ECX, EAX);  // 0x740.
+  __ pushl(Immediate(0xF6FF));
+  __ andl(ECX, Address(ESP, 0));  // 0x640.
+  __ popl(EAX);  // Discard.
   __ movl(EAX, Immediate(1));
-  __ orl(ECX, EAX);
-  __ xorl(ECX, Immediate(0));
+  __ orl(ECX, EAX);  // 0x641.
+  __ pushl(Immediate(0x7));
+  __ orl(ECX, Address(ESP, 0));  // 0x647.
+  __ popl(EAX);  // Discard.
+  __ xorl(ECX, Immediate(0));  // 0x647.
+  __ pushl(Immediate(0x1C));
+  __ xorl(ECX, Address(ESP, 0));  // 0x65B.
+  __ popl(EAX);  // Discard.
   __ movl(EAX, ECX);
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(Bitwise, test) {
   typedef int (*Bitwise)();
-  EXPECT_EQ(256 + 1, reinterpret_cast<Bitwise>(test->entry())());
+  EXPECT_EQ(0x65B, reinterpret_cast<Bitwise>(test->entry())());
 }
 
 
 ASSEMBLER_TEST_GENERATE(LogicalOps, assembler) {
   Label donetest1;
   __ movl(EAX, Immediate(4));
   __ andl(EAX, Immediate(2));
   __ cmpl(EAX, Immediate(0));
   __ j(EQUAL, &donetest1);
   // Be sure to skip this crashing code.
@@ skipping 2192 matching lines @@
                      FieldAddress(ECX, GrowableObjectArray::data_offset()),
                      EAX);
   __ popl(EAX);
   __ popl(CTX);
   __ ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32