Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: runtime/vm/assembler_ia32.cc

Issue 16126003: Use stack locations instead of register for binary Smi operations when possible. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/heap.h" 10 #include "vm/heap.h"
(...skipping 1253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 EmitOperand(dst, Operand(src)); 1264 EmitOperand(dst, Operand(src));
1265 } 1265 }
1266 1266
1267 1267
1268 void Assembler::andl(Register dst, const Immediate& imm) { 1268 void Assembler::andl(Register dst, const Immediate& imm) {
1269 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1269 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1270 EmitComplex(4, Operand(dst), imm); 1270 EmitComplex(4, Operand(dst), imm);
1271 } 1271 }
1272 1272
1273 1273
1274 void Assembler::andl(Register dst, const Address& address) {
1275 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1276 EmitUint8(0x23);
1277 EmitOperand(dst, address);
1278 }
1279
1280
1274 void Assembler::orl(Register dst, Register src) { 1281 void Assembler::orl(Register dst, Register src) {
1275 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1282 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1276 EmitUint8(0x0B); 1283 EmitUint8(0x0B);
1277 EmitOperand(dst, Operand(src)); 1284 EmitOperand(dst, Operand(src));
1278 } 1285 }
1279 1286
1280 1287
1281 void Assembler::orl(Register dst, const Immediate& imm) { 1288 void Assembler::orl(Register dst, const Immediate& imm) {
1282 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1289 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1283 EmitComplex(1, Operand(dst), imm); 1290 EmitComplex(1, Operand(dst), imm);
1284 } 1291 }
1285 1292
1286 1293
1294 void Assembler::orl(Register dst, const Address& address) {
1295 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1296 EmitUint8(0x0B);
1297 EmitOperand(dst, address);
1298 }
1299
1300
1287 void Assembler::xorl(Register dst, Register src) { 1301 void Assembler::xorl(Register dst, Register src) {
1288 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1302 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1289 EmitUint8(0x33); 1303 EmitUint8(0x33);
1290 EmitOperand(dst, Operand(src)); 1304 EmitOperand(dst, Operand(src));
1291 } 1305 }
1292 1306
1293 1307
1294 void Assembler::xorl(Register dst, const Immediate& imm) { 1308 void Assembler::xorl(Register dst, const Immediate& imm) {
1295 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1309 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1296 EmitComplex(6, Operand(dst), imm); 1310 EmitComplex(6, Operand(dst), imm);
1297 } 1311 }
1298 1312
1299 1313
1314 void Assembler::xorl(Register dst, const Address& address) {
1315 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1316 EmitUint8(0x33);
1317 EmitOperand(dst, address);
1318 }
1319
1320
1300 void Assembler::addl(Register reg, const Immediate& imm) { 1321 void Assembler::addl(Register reg, const Immediate& imm) {
1301 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1322 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1302 EmitComplex(0, Operand(reg), imm); 1323 EmitComplex(0, Operand(reg), imm);
1303 } 1324 }
1304 1325
1305 1326
1306 void Assembler::addl(const Address& address, Register reg) { 1327 void Assembler::addl(const Address& address, Register reg) {
1307 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1328 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1308 EmitUint8(0x01); 1329 EmitUint8(0x01);
1309 EmitOperand(reg, address); 1330 EmitOperand(reg, address);
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
2356 2377
2357 const char* Assembler::FpuRegisterName(FpuRegister reg) { 2378 const char* Assembler::FpuRegisterName(FpuRegister reg) {
2358 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 2379 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
2359 return xmm_reg_names[reg]; 2380 return xmm_reg_names[reg];
2360 } 2381 }
2361 2382
2362 2383
2363 } // namespace dart 2384 } // namespace dart
2364 2385
2365 #endif // defined TARGET_ARCH_IA32 2386 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698