Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1612583002: Clear StartTracingDoneCallback after usage (Closed)

Created:
4 years, 11 months ago by Zhen Wang
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear StartTracingDoneCallback after usage Currently StartTracingDoneCallback is not cleared after it is used. This CL fixes it. BUG=542390 Committed: https://crrev.com/e77ab9d122f0c28a9fd59e6cc9c884cd71a710d2 Cr-Commit-Position: refs/heads/master@{#370811}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/tracing/tracing_controller_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Zhen Wang
ptal
4 years, 11 months ago (2016-01-20 19:38:25 UTC) #3
shatch
lgtm
4 years, 11 months ago (2016-01-21 15:41:11 UTC) #5
oystein (OOO til 10th of July)
https://codereview.chromium.org/1612583002/diff/1/content/browser/tracing/tracing_controller_impl.cc File content/browser/tracing/tracing_controller_impl.cc (right): https://codereview.chromium.org/1612583002/diff/1/content/browser/tracing/tracing_controller_impl.cc#newcode274 content/browser/tracing/tracing_controller_impl.cc:274: start_tracing_done_callback_ = StartTracingDoneCallback(); I think you can do start_tracing_done_callback_.Reset()?
4 years, 11 months ago (2016-01-21 15:57:03 UTC) #6
oystein (OOO til 10th of July)
other than that: lgtm
4 years, 11 months ago (2016-01-21 15:57:16 UTC) #7
Zhen Wang
Thanks guys! :) https://codereview.chromium.org/1612583002/diff/1/content/browser/tracing/tracing_controller_impl.cc File content/browser/tracing/tracing_controller_impl.cc (right): https://codereview.chromium.org/1612583002/diff/1/content/browser/tracing/tracing_controller_impl.cc#newcode274 content/browser/tracing/tracing_controller_impl.cc:274: start_tracing_done_callback_ = StartTracingDoneCallback(); On 2016/01/21 15:57:03, ...
4 years, 11 months ago (2016-01-21 21:14:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612583002/20001
4 years, 11 months ago (2016-01-21 21:15:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 22:44:01 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:45:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e77ab9d122f0c28a9fd59e6cc9c884cd71a710d2
Cr-Commit-Position: refs/heads/master@{#370811}

Powered by Google App Engine
This is Rietveld 408576698