Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1612543003: replace arcto quads with a conic (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -28 lines) Patch
M samplecode/SampleQuadStroker.cpp View 13 chunks +106 lines, -23 lines 0 comments Download
M src/core/SkGeometry.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkPath.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612543003/1
4 years, 11 months ago (2016-01-20 19:24:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 19:35:06 UTC) #6
caryclark
The Chrome legacy flag has landed. This fixes the recently landed arccirclegap gm. The QuadStroker ...
4 years, 11 months ago (2016-01-20 19:45:51 UTC) #7
reed1
lgtm
4 years, 11 months ago (2016-01-20 19:52:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612543003/1
4 years, 11 months ago (2016-01-20 19:54:36 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:55:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/88651aeb551fb02003a7600679e8e7df8a589e7f

Powered by Google App Engine
This is Rietveld 408576698