Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1612533002: Add support for Uint32 fields and lists in Flat Buffers. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for Uint32 fields and lists in Flat Buffers. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e53f7e7a88dc93361d193c5ff211fab2aa4595c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 4 chunks +50 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-20 17:46:43 UTC) #1
Paul Berry
lgtm
4 years, 11 months ago (2016-01-20 17:48:30 UTC) #2
scheglov
4 years, 11 months ago (2016-01-20 17:49:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e53f7e7a88dc93361d193c5ff211fab2aa4595c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698