Make new StreamController be async by default.

sdk/lib/html/dart2js/html_dart2js.dart

 /// The Dart HTML library.
 library dart.dom.html;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_collection-dev' hide Symbol;
 import 'dart:html_common';
 import 'dart:indexed_db';
 import 'dart:isolate';
 import 'dart:json' as json;
@@ skipping 5943 matching lines @@
 }
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DomName('DirectoryEntry')
 // http://www.w3.org/TR/file-system-api/#the-directoryentry-interface
 @Experimental
 class DirectoryEntry extends Entry native "DirectoryEntry" {
-  
+
   /**
    * Create a new directory with the specified `path`. If `exclusive` is true,
    * the returned Future will complete with an error if a directory already
    * exists with the specified `path`.
    */
   Future<Entry> createDirectory(String path, {bool exclusive: false}) {
-    return _getDirectory(path, options: 
+    return _getDirectory(path, options:
         {'create': true, 'exclusive': exclusive});
   }
 
   /**
    * Retrieve an already existing directory entry. The returned future will
    * result in an error if a directory at `path` does not exist or if the item
    * at `path` is not a directory.
    */
   Future<Entry> getDirectory(String path) {
     return _getDirectory(path);
   }
 
   /**
    * Create a new file with the specified `path`. If `exclusive` is true,
    * the returned Future will complete with an error if a file already
    * exists at the specified `path`.
    */
   Future<Entry> createFile(String path, {bool exclusive: false}) {
     return _getFile(path, options: {'create': true, 'exclusive': exclusive});
   }
-  
+
   /**
    * Retrieve an already existing file entry. The returned future will
    * result in an error if a file at `path` does not exist or if the item at
    * `path` is not a file.
    */
   Future<Entry> getFile(String path) {
     return _getFile(path);
   }
 
   @DomName('DirectoryEntry.createReader')
@@ skipping 4620 matching lines @@
     }
     if (timeout != null) {
       options['timeout'] = timeout.inMilliseconds;
     }
     if (maximumAge != null) {
       options['maximumAge'] = maximumAge.inMilliseconds;
     }
 
     int watchId;
     var controller;
-    controller = new StreamController<Geoposition>(
+    controller = new StreamController<Geoposition>(sync: true,
       onListen: () {
         assert(watchId == null);
         watchId = $dom_watchPosition(
             (position) {
               controller.add(_ensurePosition(position));
             },
             (error) {
               controller.addError(error);
             },
             options);
@@ skipping 4733 matching lines @@
    *
    * Simple example usage:
    *
    *     window.navigator.getUserMedia(audio: true, video: true).then((stream) {
    *       var video = new VideoElement()
    *         ..autoplay = true
    *         ..src = Url.createObjectUrl(stream);
    *       document.body.append(video);
    *     });
    *
-   * The user can also pass in Maps to the audio or video parameters to specify 
-   * mandatory and optional constraints for the media stream. Not passing in a 
-   * map, but passing in `true` will provide a MediaStream with audio or 
+   * The user can also pass in Maps to the audio or video parameters to specify
+   * mandatory and optional constraints for the media stream. Not passing in a
+   * map, but passing in `true` will provide a MediaStream with audio or
    * video capabilities, but without any additional constraints. The particular
-   * constraint names for audio and video are still in flux, but as of this 
+   * constraint names for audio and video are still in flux, but as of this
    * writing, here is an example providing more constraints.
    *
    *     window.navigator.getUserMedia(
-   *         audio: true, 
-   *         video: {'mandatory': 
+   *         audio: true,
+   *         video: {'mandatory':
    *                    { 'minAspectRatio': 1.333, 'maxAspectRatio': 1.334 },
-   *                 'optional': 
+   *                 'optional':
    *                    [{ 'minFrameRate': 60 },
    *                     { 'maxWidth': 640 }]
    *     });
    *
    * See also:
    * * [MediaStream.supported]
    */
   @DomName('Navigator.webkitGetUserMedia')
   @SupportedBrowser(SupportedBrowser.CHROME)
   @Experimental
@@ skipping 826 matching lines @@
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DomName('Notification')
 // http://www.w3.org/TR/notifications/#notification
 @Experimental // experimental
 class Notification extends EventTarget native "Notification" {
 
-  factory Notification(String title, {String titleDir: null, String body: null, 
+  factory Notification(String title, {String titleDir: null, String body: null,
       String bodyDir: null, String tag: null, String iconUrl: null}) {
 
     var parsedOptions = {};
     if (titleDir != null) parsedOptions['titleDir'] = titleDir;
     if (body != null) parsedOptions['body'] = body;
     if (bodyDir != null) parsedOptions['bodyDir'] = bodyDir;
     if (tag != null) parsedOptions['tag'] = tag;
     if (iconUrl != null) parsedOptions['iconUrl'] = iconUrl;
 
     return Notification._factoryNotification(title, parsedOptions);
@@ skipping 1607 matching lines @@
 @DomName('RTCIceCandidate')
 @SupportedBrowser(SupportedBrowser.CHROME)
 @Experimental
 // http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCIceCandidate
 class RtcIceCandidate native "RTCIceCandidate,mozRTCIceCandidate" {
   factory RtcIceCandidate(Map dictionary) {
     // TODO(efortuna): Remove this check if when you can actually construct with
     // the unprefixed RTCIceCandidate in Firefox (currently both are defined,
     // but one can't be used as a constructor).
     var constructorName = JS('', 'window[#]',
-        Device.isFirefox ? '${Device.propertyPrefix}RTCIceCandidate' : 
+        Device.isFirefox ? '${Device.propertyPrefix}RTCIceCandidate' :
         'RTCIceCandidate');
     return JS('RtcIceCandidate', 'new #(#)', constructorName,
         convertDartToNative_SerializedScriptValue(dictionary));
   }
 
   @DomName('RTCIceCandidate.candidate')
   @DocsEditable
   final String candidate;
 
   @DomName('RTCIceCandidate.sdpMLineIndex')
@@ skipping 44 matching lines @@
   }
 
   /**
    * Checks if Real Time Communication (RTC) APIs are supported and enabled on
    * the current platform.
    */
   static bool get supported {
     // Currently in Firefox some of the RTC elements are defined but throw an
     // error unless the user has specifically enabled them in their
     // about:config. So we have to construct an element to actually test if RTC
-    // is supported at the given time. 
+    // is supported at the given time.
     try {
       new RtcPeerConnection(
           {"iceServers": [ {"url":"stun:localhost"}]});
       return true;
     } catch (_) { return false;}
     return false;
   }
   Future<RtcSessionDescription> createOffer([Map mediaConstraints]) {
     var completer = new Completer<RtcSessionDescription>();
     _createOffer(
@@ skipping 282 matching lines @@
 @DomName('RTCSessionDescription')
 @SupportedBrowser(SupportedBrowser.CHROME)
 @Experimental
 // http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCSessionDescription
 class RtcSessionDescription native "RTCSessionDescription,mozRTCSessionDescription" {
   factory RtcSessionDescription(Map dictionary) {
     // TODO(efortuna): Remove this check if when you can actually construct with
     // the unprefixed RTCIceCandidate in Firefox (currently both are defined,
     // but one can't be used as a constructor).
     var constructorName = JS('', 'window[#]',
-        Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' : 
+        Device.isFirefox ? '${Device.propertyPrefix}RTCSessionDescription' :
        'RTCSessionDescription');
-    return JS('RtcSessionDescription', 
+    return JS('RtcSessionDescription',
         'new #(#)', constructorName,
         convertDartToNative_SerializedScriptValue(dictionary));
   }
 
   @DomName('RTCSessionDescription.sdp')
   @DocsEditable
   String sdp;
 
   @DomName('RTCSessionDescription.type')
   @DocsEditable
@@ skipping 1654 matching lines @@
     var completer = new Completer<int>();
     _requestQuota(storageType, newQuotaInBytes,
         (value) { completer.complete(value); },
         (error) { completer.completeError(error); });
     return completer.future;
   }
 
   Future<StorageInfoUsage> queryUsageAndQuota(int storageType) {
     var completer = new Completer<StorageInfoUsage>();
     _queryUsageAndQuota(storageType,
-        (currentUsageInBytes, currentQuotaInBytes) { 
-          completer.complete(new StorageInfoUsage(currentUsageInBytes, 
+        (currentUsageInBytes, currentQuotaInBytes) {
+          completer.complete(new StorageInfoUsage(currentUsageInBytes,
               currentQuotaInBytes));
         },
         (error) { completer.completeError(error); });
     return completer.future;
   }
 }
 
-/** 
+/**
  * A simple container class for the two values that are returned from the
  * futures in requestQuota and queryUsageAndQuota.
  */
 class StorageInfoUsage {
   final int currentUsageInBytes;
   final int currentQuotaInBytes;
   const StorageInfoUsage(this.currentUsageInBytes, this.currentQuotaInBytes);
 }
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
@@ skipping 422 matching lines @@
    * should not be used in your code.
    *
    * This event is fired whenever a template is instantiated via
    * [createInstance].
    */
   // TODO(rafaelw): This is a hack, and is neccesary for the polyfill
   // because custom elements are not upgraded during clone()
   @Experimental
   static Stream<DocumentFragment> get instanceCreated {
     if (_instanceCreated == null) {
-      _instanceCreated = new StreamController<DocumentFragment>();
+      _instanceCreated = new StreamController<DocumentFragment>(sync: true);
     }
     return _instanceCreated.stream;
   }
 
   /**
    * Ensures proper API and content model for template elements.
    *
    * [instanceRef] can be used to set the [Element.ref] property of [template],
    * and use the ref's content will be used as source when createInstance() is
    * invoked.
@@ skipping 2906 matching lines @@
   }
 }
 
 class _BeforeUnloadEventStreamProvider implements
     EventStreamProvider<BeforeUnloadEvent> {
   final String _eventType;
 
   const _BeforeUnloadEventStreamProvider(this._eventType);
 
   Stream<BeforeUnloadEvent> forTarget(EventTarget e, {bool useCapture: false}) {
-    var controller = new StreamController();
+    var controller = new StreamController(sync: true);
     var stream = new _EventStream(e, _eventType, useCapture);
     stream.listen((event) {
       var wrapped = new _BeforeUnloadEvent(event);
       controller.add(wrapped);
       return wrapped.returnValue;
     });
 
     return controller.stream;
   }
 
@@ skipping 2320 matching lines @@
   /** The type of KeyEvent we are tracking (keyup, keydown, keypress). */
   final String _type;
 
   /** The element we are watching for events to happen on. */
   final EventTarget _target;
 
   // The distance to shift from upper case alphabet Roman letters to lower case.
   static final int _ROMAN_ALPHABET_OFFSET = "a".codeUnits[0] - "A".codeUnits[0];
 
   /** Controller to produce KeyEvents for the stream. */
-  final StreamController _controller = new StreamController();
+  final StreamController _controller = new StreamController(sync: true);
 
   static const _EVENT_TYPE = 'KeyEvent';
 
   /**
    * An enumeration of key identifiers currently part of the W3C draft for DOM3
    * and their mappings to keyCodes.
    * http://www.w3.org/TR/DOM-Level-3-Events/keyset.html#KeySet-Set
    */
   static const Map<String, int> _keyIdentifier = const {
     'Up': KeyCode.UP,
@@ skipping 48 matching lines @@
    * KeyboardEvent controller.
    */
   _KeyboardEventHandler(this._type) :
     _target = null, super(_EVENT_TYPE) {
   }
 
   /**
    * Hook up all event listeners under the covers so we can estimate keycodes
    * and charcodes when they are not provided.
    */
-  _KeyboardEventHandler.initializeAllEventListeners(this._type, this._target) : 
+  _KeyboardEventHandler.initializeAllEventListeners(this._type, this._target) :
     super(_EVENT_TYPE) {
     Element.keyDownEvent.forTarget(_target, useCapture: true).listen(
         processKeyDown);
     Element.keyPressEvent.forTarget(_target, useCapture: true).listen(
         processKeyPress);
     Element.keyUpEvent.forTarget(_target, useCapture: true).listen(
         processKeyUp);
   }
 
   /**
@@ skipping 1124 matching lines @@
    * Observes [path] on [object] for changes. This returns an object that can be
    * used to get the changes and get/set the value at this path.
    * See [PathObserver.values] and [PathObserver.value].
    */
   PathObserver(this.object, String path)
     : path = path, _isValid = _isPathValid(path) {
 
     // TODO(jmesserly): if the path is empty, or the object is! Observable, we
     // can optimize the PathObserver to be more lightweight.
 
-    _values = new StreamController.broadcast(onListen: _observe,
+    _values = new StreamController.broadcast(sync: true,
+                                             onListen: _observe,
                                              onCancel: _unobserve);
 
     if (_isValid) {
       var segments = [];
       for (var segment in path.trim().split('.')) {
         if (segment == '') continue;
         var index = int.parse(segment, onError: (_) {});
         segments.add(index != null ? index : new Symbol(segment));
       }
 
@@ skipping 2390 matching lines @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // Iterator for arrays with fixed size.
 class FixedSizeListIterator<T> implements Iterator<T> {
   final List<T> _array;
   final int _length;  // Cache array length for faster access.
   int _position;
   T _current;
-  
+
   FixedSizeListIterator(List<T> array)
       : _array = array,
         _position = -1,
         _length = array.length;
 
   bool moveNext() {
     int nextPosition = _position + 1;
     if (nextPosition < _length) {
       _current = _array[nextPosition];
       _position = nextPosition;
@@ skipping 24 matching lines @@
       _position = nextPosition;
       return true;
     }
     _current = null;
     _position = _array.length;
     return false;
   }
 
   T get current => _current;
 }