Make new StreamController be async by default.

sdk/lib/_internal/pub/test/error_group_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library error_group_test;
 
 import 'dart:async';
 
 import 'package:unittest/unittest.dart';
 
@@ skipping 20 matching lines @@
       errorGroup.signalError(new FormatException());
     });
 
     test("shouldn't allow additional futures or streams once an error has been "
         "signaled", () {
       expect(errorGroup.done, throwsFormatException);
       errorGroup.signalError(new FormatException());
 
       expect(() => errorGroup.registerFuture(new Future.value()),
           throwsStateError);
-      expect(() => errorGroup.registerStream(new StreamController().stream),
+      expect(() => errorGroup.registerStream(new StreamController(sync: true).stream),

[floitsch, 2013/05/30 12:13:48]

long line.

[Lasse Reichstein Nielsen, 2013/05/31 05:51:59]

Done.

           throwsStateError);
     });
   });
 
   group('with a single future', () {
     Completer completer;
     Future future;
 
     setUp(() {
       errorGroup = new ErrorGroup();
       completer = new Completer();
       future = errorGroup.registerFuture(completer.future);
     });
 
     test('should pass through a value from the future', () {
       expect(future, completion(equals('value')));
       expect(errorGroup.done, completes);
       completer.complete('value');
     });
 
     test("shouldn't allow additional futures or streams once .done has "
         "been called", () {
       completer.complete('value');
 
       completer.future.then(expectAsync1((_) {
         expect(() => errorGroup.registerFuture(new Future.value()),
             throwsStateError);
-        expect(() => errorGroup.registerStream(new StreamController().stream),
+        expect(() => errorGroup.registerStream(new StreamController(sync: true).stream),

[floitsch, 2013/05/30 12:13:48]

ditto.

[Lasse Reichstein Nielsen, 2013/05/31 05:51:59]

Done.

             throwsStateError);
       }));
     });
 
     test('should pass through an exception from the future if it has a '
         'listener', () {
       expect(future, throwsFormatException);
       // errorGroup shouldn't top-level the exception
       completer.completeError(new FormatException());
     });
@@ skipping 118 matching lines @@
       }), completes);
     });
   });
 
   group('with a single stream', () {
     StreamController controller;
     Stream stream;
 
     setUp(() {
       errorGroup = new ErrorGroup();
-      controller = new StreamController();
+      controller = new StreamController(sync: true);
       stream = errorGroup.registerStream(controller.stream.asBroadcastStream());
     });
 
     test('should pass through values from the stream', () {
       StreamIterator iter = new StreamIterator(stream);
       iter.moveNext().then((hasNext) {
         expect(hasNext, isTrue);
         expect(iter.current, equals(1));
         iter.moveNext().then((hasNext) {
           expect(hasNext, isTrue);
@@ skipping 51 matching lines @@
     });
 
   });
 
   group('with a single single-subscription stream', () {
     StreamController controller;
     Stream stream;
 
     setUp(() {
       errorGroup = new ErrorGroup();
-      controller = new StreamController();
+      controller = new StreamController(sync: true);
       stream = errorGroup.registerStream(controller.stream);
     });
 
     test("should complete .done when the stream is done even if the stream "
         "doesn't have a listener", () {
       expect(errorGroup.done, completes);
       controller.add('value');
       controller.close();
 
       // A listener added afterwards should receive the value
@@ skipping 28 matching lines @@
   });
 
   group('with multiple streams', () {
     StreamController controller1;
     StreamController controller2;
     Stream stream1;
     Stream stream2;
 
     setUp(() {
       errorGroup = new ErrorGroup();
-      controller1 = new StreamController();
-      controller2 = new StreamController();
+      controller1 = new StreamController(sync: true);
+      controller2 = new StreamController(sync: true);
       stream1 = errorGroup.registerStream(controller1.stream.asBroadcastStream());
       stream2 = errorGroup.registerStream(controller2.stream.asBroadcastStream());
     });
 
     test("should pipe exceptions from one stream to the other and to .done",
         () {
       expect(stream1.first, throwsFormatException);
       expect(stream2.first, throwsFormatException);
       expect(errorGroup.done, throwsFormatException);
 
@@ skipping 37 matching lines @@
   });
 
   group('with a stream and a future', () {
     StreamController controller;
     Stream stream;
     Completer completer;
     Future future;
 
     setUp(() {
       errorGroup = new ErrorGroup();
-      controller = new StreamController();
+      controller = new StreamController(sync: true);
       stream = errorGroup.registerStream(controller.stream.asBroadcastStream());
       completer = new Completer();
       future = errorGroup.registerFuture(completer.future);
     });
 
     test("should pipe exceptions from the stream to the future", () {
       expect(stream.first, throwsFormatException);
       expect(future, throwsFormatException);
       expect(errorGroup.done, throwsFormatException);
 
@@ skipping 36 matching lines @@
              completion(equals(['value1', 'value2'])));
       controller..add('value1')..add('value2')..close();
 
       expect(signal.future.then((_) {
         // shouldn't cause a top-level exception
         completer.completeError(new FormatException());
       }), completes);
     });
   });
 }