Add pre_log option to nanobench; make this option default true in nanobench and dm.

Add pre_log option to nanobench; make this option default true in nanobench_flags.py and dm_flags.py.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612483002

Committed: https://skia.googlesource.com/skia/+/8d61f0dd1b6fde5202a14dfafcc1bceccf0d74ad

[dogben, 2016-01-20 16:29:33]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[dogben, 2016-01-20 16:29:35]

Description was changed from

==========
Add pre_log option to nanobench; make this option default true in nanobench and
dm.

BUG=skia:4826
BUG=skia:4827
==========

to

==========
Add pre_log option to nanobench; make this option default true in nanobench and
dm.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-01-20 16:29:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612483002/1

[commit-bot: I haz the power, 2016-01-20 16:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 16:32:39]

Dry run: Try jobs failed on following builders:
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)

[dogben, 2016-01-20 18:00:32]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 18:00:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612483002/20001

[commit-bot: I haz the power, 2016-01-20 18:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 18:12:20]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-01-20 18:13:42]

benjaminwagner@google.com changed reviewers:
+ reed@google.com

[dogben, 2016-01-22 17:45:09]

ping

[mtklein, 2016-01-22 18:08:32]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-22 18:08:33]

https://codereview.chromium.org/1612483002/diff/20001/tools/flags/SkCommonFla...
File tools/flags/SkCommonFlags.cpp (right):

https://codereview.chromium.org/1612483002/diff/20001/tools/flags/SkCommonFla...
tools/flags/SkCommonFlags.cpp:51: DEFINE_bool2(pre_log, p, true, "Log before
running each test. May be incomprehensible when threading");
Let's enable this by default only on the bots (editing dm_flags.py +
nanobench_flags.py),
or make it work well with line-overwriting when not using --verbose (generally,
this just means moving a \n from the end of the message to the front).

[dogben, 2016-01-25 19:37:56]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 19:38:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612483002/40001

[dogben, 2016-01-25 19:38:16]

https://codereview.chromium.org/1612483002/diff/20001/tools/flags/SkCommonFla...
File tools/flags/SkCommonFlags.cpp (right):

https://codereview.chromium.org/1612483002/diff/20001/tools/flags/SkCommonFla...
tools/flags/SkCommonFlags.cpp:51: DEFINE_bool2(pre_log, p, true, "Log before
running each test. May be incomprehensible when threading");
On 2016/01/22 at 18:08:33, mtklein wrote:
> Let's enable this by default only on the bots (editing dm_flags.py +
nanobench_flags.py),
> or make it work well with line-overwriting when not using --verbose
(generally, this just means moving a \n from the end of the message to the
front).

The result with line-overwriting ended up being unsatisfactory because there are
some very long test names that caused wrapping in the terminal, at which point
kSkOverwriteLine doesn't do what we want.

[dogben, 2016-01-25 19:38:47]

Description was changed from

==========
Add pre_log option to nanobench; make this option default true in nanobench and
dm.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add pre_log option to nanobench; make this option default true in
nanobench_flags.py and dm_flags.py.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-25 19:44:35]

https://codereview.chromium.org/1612483002/diff/40001/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1612483002/diff/40001/bench/nanobench.cpp#new...
bench/nanobench.cpp:1042: FLAGS_pre_log = true;
Ditto

https://codereview.chromium.org/1612483002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1612483002/diff/40001/dm/DM.cpp#newcode1130
dm/DM.cpp:1130: FLAGS_pre_log = true;
?  Let's let people set independent things independently.

[commit-bot: I haz the power, 2016-01-25 19:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:50:53]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-01-25 20:18:00]

Sorry, my previous diff was incorrect.

https://codereview.chromium.org/1612483002/diff/40001/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1612483002/diff/40001/bench/nanobench.cpp#new...
bench/nanobench.cpp:1042: FLAGS_pre_log = true;
On 2016/01/25 at 19:44:35, mtklein wrote:
> Ditto

Done.

https://codereview.chromium.org/1612483002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1612483002/diff/40001/dm/DM.cpp#newcode1130
dm/DM.cpp:1130: FLAGS_pre_log = true;
On 2016/01/25 at 19:44:35, mtklein wrote:
> ?  Let's let people set independent things independently.

Done.

[dogben, 2016-01-25 20:38:24]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 20:38:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612483002/60001

[commit-bot: I haz the power, 2016-01-25 20:49:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 20:49:25]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-01-25 20:55:42]

lgtm

[dogben, 2016-01-25 20:59:38]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-01-25 20:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612483002/60001

[commit-bot: I haz the power, 2016-01-25 21:02:43]

Description was changed from

==========
Add pre_log option to nanobench; make this option default true in
nanobench_flags.py and dm_flags.py.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add pre_log option to nanobench; make this option default true in
nanobench_flags.py and dm_flags.py.

BUG=skia:4826
BUG=skia:4827
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8d61f0dd1b6fde5202a14dfafcc1bceccf0d74ad
==========

[commit-bot: I haz the power, 2016-01-25 21:02:44]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8d61f0dd1b6fde5202a14dfafcc1bceccf0d74ad