Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1612453002:
[Refactoring] Remove squaredDistanceToClosestPoint function on LayoutSVGInlineText.cpp (Closed)
|
Created:
4 years, 11 months ago by hyunjunekim2 Modified:
4 years, 11 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove squaredDistanceToClosestPoint function
Use FloatRect::squaredDistanceTo.
BUG=445329
Committed: https://crrev.com/ec9931b6a84f86605970d9aab571d2ca429df2fa
Cr-Commit-Position: refs/heads/master@{#370629}
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Refactoring BUG= ========== to ========== Refactoring BUG= ==========
Description was changed from ========== Refactoring BUG= ========== to ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn- lineText.cpp Because latest implemented squaredDistanceTo to calculate dis- tance between FloatPoint and FloatRect. BUG= ==========
Description was changed from ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn- lineText.cpp Because latest implemented squaredDistanceTo to calculate dis- tance between FloatPoint and FloatRect. BUG= ========== to ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn- lineText.cpp Because latest implemented squaredDistanceTo to calculate dis- tance between FloatPoint and FloatRect. BUG=445329 ==========
hyunjune.kim@samsung.com changed reviewers: + fs@opera.com, pdr@chromium.org
Could you check this patch? Thank you.
On 2016/01/20 at 15:16:18, hyunjune.kim wrote: > Could you check this patch? Thank you. Fix the description to not wrap on the first (subject) line. > Because latest implemented squaredDistanceTo to calculate dis- > tance between FloatPoint and FloatRect. Same thing about wrapping here (just wrap whole words - don't add hyphens). I'm not sure what "Because latest implemented" is supposed to mean? "Use FloatRect::squaredDistanceTo" would suffice as far as I'm concerned.
Description was changed from ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn- lineText.cpp Because latest implemented squaredDistanceTo to calculate dis- tance between FloatPoint and FloatRect. BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn lineText.cpp Because support FloatRect::squaredDistanceTo to calculate dis tance between FloatPoint and FloatRect. BUG=445329 ==========
How do you look this description?
On 2016/01/20 at 15:36:27, hyunjune.kim wrote: > How do you look this description? Better but still wrapped (just without the hyphen.)
Description was changed from ========== Remove squaredDistanceToClosestPoint function on LayoutSVGIn lineText.cpp Because support FloatRect::squaredDistanceTo to calculate dis tance between FloatPoint and FloatRect. BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function Because support FloatRect::squaredDistanceTo to calculate dis tance between FloatPoint and FloatRect. BUG=445329 ==========
On 2016/01/20 15:37:58, fs wrote: > On 2016/01/20 at 15:36:27, hyunjune.kim wrote: > > How do you look this description? > > Better but still wrapped (just without the hyphen.) Make the subject one line.
Description was changed from ========== Remove squaredDistanceToClosestPoint function Because support FloatRect::squaredDistanceTo to calculate dis tance between FloatPoint and FloatRect. BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo BUG=445329 ==========
fs, Could you check this description? Thank you.
Description was changed from ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo. BUG=445329 ==========
lgtm
The CQ bit was checked by hyunjune.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612453002/1
Message was sent while issue was closed.
Description was changed from ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo. BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo. BUG=445329 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo. BUG=445329 ========== to ========== Remove squaredDistanceToClosestPoint function Use FloatRect::squaredDistanceTo. BUG=445329 Committed: https://crrev.com/ec9931b6a84f86605970d9aab571d2ca429df2fa Cr-Commit-Position: refs/heads/master@{#370629} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ec9931b6a84f86605970d9aab571d2ca429df2fa Cr-Commit-Position: refs/heads/master@{#370629} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
