content/browser/service_worker/service_worker_url_request_job.cc - Issue 1612423002: Don't send the body of the redirected request to the ServiceWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 1612423002: Don't send the body of the redirected request to the ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add LayoutTest Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc

index 44fab7f581af4ebfec85d300efe60def2206de1e..8faed6e7a2065e6802ef9a9cb02ea255cd34ca67 100644

--- a/content/browser/service_worker/service_worker_url_request_job.cc

+++ b/content/browser/service_worker/service_worker_url_request_job.cc

@@ -446,7 +446,9 @@ scoped_ptr<ServiceWorkerFetchRequest>

ServiceWorkerURLRequestJob::CreateFetchRequest() {

std::string blob_uuid;

uint64_t blob_size = 0;

- CreateRequestBodyBlob(&blob_uuid, &blob_size);

+ // The upload data in URLRequest may have been cleared while handing redirect.

+ if (request_->has_upload())

+ CreateRequestBodyBlob(&blob_uuid, &blob_size);

scoped_ptr<ServiceWorkerFetchRequest> request(

new ServiceWorkerFetchRequest());

request->mode = request_mode_;