src/elements.cc - Issue 1612413003: Reland of [runtime] Do not use the enum-cache for non-prototype objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 1612413003: Reland of [runtime] Do not use the enum-cache for non-prototype objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index 16e8b067cf9273b15fc0dd291b4ad0471d47a721..839d833c945563b21409af80cb6814814ab2674b 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -1153,7 +1153,12 @@

if (!AccessorInfo::cast(accessors)->all_can_read()) continue;

}

PropertyAttributes attr = details.attributes();

- if ((attr & filter) != 0) continue;

+ if ((attr & filter) != 0) {

+ if (attr & PropertyAttributes::DONT_ENUM) {

+ keys->HideKey(index);

+ }

+ continue;

+ }

keys->AddKey(index);

}

« no previous file with comments | « no previous file | src/key-accumulator.h » ('j') | no next file with comments »