Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1612403002: ll_prof: add decimal offset (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ll_prof: add decimal offset This simplifies correlating offsets with the output from --print-opt-code, which outputs offsets in decimal. We keep the hex output since branch instructions in the perf dump use hex labels. We just include the decimal offset along with the hex offset. BUG= Committed: https://crrev.com/379bbd502466b618761198119d466ec5687205d0 Cr-Commit-Position: refs/heads/master@{#33455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/ll_prof.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-22 06:07:23 UTC) #3
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-22 06:22:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612403002/1
4 years, 11 months ago (2016-01-22 06:23:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 06:41:09 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 06:41:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379bbd502466b618761198119d466ec5687205d0
Cr-Commit-Position: refs/heads/master@{#33455}

Powered by Google App Engine
This is Rietveld 408576698