Remove dependency of WebData on notifications

Remove dependency of WebData on notifications

The notification code was actually unused in WebData. This CL removes the code
and enforces the lack of dependency.

BUG=248049
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205269

[droger, 2013-06-06 15:25:02]

blundell for a first pass on the CL.

[droger, 2013-06-06 15:26:39]

On 2013/06/06 15:25:02, droger wrote:
> blundell for a first pass on the CL.

Oops, forgot about DEPS rules, I'll see if I can add something to enforce the
non-dependency.

[blundell, 2013-06-06 15:47:47]

On 2013/06/06 15:26:39, droger wrote:
> On 2013/06/06 15:25:02, droger wrote:
> > blundell for a first pass on the CL.
> 
> Oops, forgot about DEPS rules, I'll see if I can add something to enforce the
> non-dependency.

Let's do a blanket restriction and then allow BrowserThread. Also please
add/augment the README to explain the reason for this restriction: that this
component is shared by iOS.

[droger, 2013-06-06 16:00:11]

Thanks, done.

[blundell, 2013-06-06 16:28:43]

+joi for review

Looks fine to me

https://codereview.chromium.org/16124006/diff/13001/components/webdata/README
File components/webdata/README (right):

https://codereview.chromium.org/16124006/diff/13001/components/webdata/README...
components/webdata/README:1: WebData is not allowed to depend on content/,
because it is used by iOS.
I would add a second sentence: "If dependences on content/ need to be added to
WebData, it will have to be made into a layered component (<link to layered
components design doc>)."

[droger, 2013-06-06 16:33:14]

https://codereview.chromium.org/16124006/diff/13001/components/webdata/README
File components/webdata/README (right):

https://codereview.chromium.org/16124006/diff/13001/components/webdata/README...
components/webdata/README:1: WebData is not allowed to depend on content/,
because it is used by iOS.
On 2013/06/06 16:28:44, blundell wrote:
> I would add a second sentence: "If dependences on content/ need to be added to
> WebData, it will have to be made into a layered component (<link to layered
> components design doc>)."

Done.

[Jói, 2013-06-06 22:17:16]

LGTM

[blundell, 2013-06-07 05:31:16]

LGTM. Could you make a bug for enabling components/webdata to be shared on iOS
and reference the bug on this CL?

https://codereview.chromium.org/16124006/diff/21001/components/webdata/README
File components/webdata/README (right):

https://codereview.chromium.org/16124006/diff/21001/components/webdata/README...
components/webdata/README:3: into a layered component, see
nit: semi-colon instead of comma here.

[droger, 2013-06-10 08:36:59]

Adding owners:

pneubeck for chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc

yoz for chrome/browser/extensions/api/identity/identity_signin_flow.cc

battre for chrome/browser/profile_resetter/profile_resetter.cc

[pneubeck (no reviews), 2013-06-10 08:48:33]

chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc LGTM

[battre, 2013-06-10 14:31:54]

https://docs.google.com/a/google.com/document/d/1dSPg71Yect5xrFn2MzhybQFiojfS...
LGTM

[battre, 2013-06-10 14:31:55]

lgtm

https://docs.google.com/a/google.com/document/d/1dSPg71Yect5xrFn2MzhybQFiojfS...
LGTM

[battre, 2013-06-10 14:33:43]

Fat fingers...

chrome/browser/profile_resetter/profile_resetter.cc LGTM

[Yoyo Zhou, 2013-06-10 16:24:52]

identity_signin_flow LGTM

[commit-bot: I haz the power, 2013-06-10 16:27:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/16124006/28001

[commit-bot: I haz the power, 2013-06-10 19:23:04]

Change committed as 205269