Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1612393002: fix embedder on Windows - fixes #25498 (Closed)

Created:
4 years, 11 months ago by danrubel
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

* fixes embedder bugs on Windows * updates embedder tests to properly test Windows R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d48687078725e477486189befd029057fe750efe

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed embedder and updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -60 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 1 6 chunks +155 lines, -51 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danrubel
https://codereview.chromium.org/1612393002/diff/1/pkg/analyzer/test/utils.dart File pkg/analyzer/test/utils.dart (right): https://codereview.chromium.org/1612393002/diff/1/pkg/analyzer/test/utils.dart#newcode17 pkg/analyzer/test/utils.dart:17: JavaFile.pathContext = context ?? path.posix; Ultimately, we need to ...
4 years, 11 months ago (2016-01-22 19:26:38 UTC) #1
danrubel
4 years, 10 months ago (2016-01-28 03:21:47 UTC) #4
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-01-28 14:20:38 UTC) #5
danrubel
4 years, 10 months ago (2016-01-28 15:51:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d48687078725e477486189befd029057fe750efe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698