Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1612383003: Fix nits on metrics_services_manager_client.h (Closed)

Created:
4 years, 11 months ago by blundell
Modified:
4 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nits on metrics_services_manager_client.h This CL addresses minor comments made on https://codereview.chromium.org/1411593004/. Committed: https://crrev.com/9eece2e91ff2eed41e24484ed5cb68547acb13ae Cr-Commit-Position: refs/heads/master@{#371222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/metrics_services_manager/metrics_services_manager_client.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
blundell
4 years, 11 months ago (2016-01-22 10:30:38 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 11 months ago (2016-01-22 15:35:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612383003/1
4 years, 11 months ago (2016-01-25 09:55:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 10:52:51 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 10:54:07 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9eece2e91ff2eed41e24484ed5cb68547acb13ae
Cr-Commit-Position: refs/heads/master@{#371222}

Powered by Google App Engine
This is Rietveld 408576698