src/debug/liveedit.cc - Issue 1612323003: Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/liveedit.cc

Issue 1612323003: Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: one more DCHECK fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/liveedit.cc

diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc

index f1f3f2391a60403c0107af3d5257b79a92c4295d..91c990d19b7d078600d7b59bc7429e3c353c1b7c 100644

--- a/src/debug/liveedit.cc

+++ b/src/debug/liveedit.cc

@@ -1857,8 +1857,8 @@ bool LiveEdit::FindActiveGenerators(Handle<FixedArray> shared_info_array,

HandleScope scope(isolate);

for (int i = 0; i < len; i++) {

- Handle<JSValue> jsvalue =

- Handle<JSValue>::cast(FixedArray::get(shared_info_array, i));

+ Handle<JSValue> jsvalue = Handle<JSValue>::cast(

+ FixedArray::get(*shared_info_array, i, isolate));

Handle<SharedFunctionInfo> shared =

UnwrapSharedFunctionInfoFromJSValue(jsvalue);

« no previous file with comments | « src/crankshaft/x87/lithium-codegen-x87.cc ('k') | src/elements.h » ('j') | no next file with comments »