Introduce {FAST,SLOW}_STRING_WRAPPER_ELEMENTS

src/key-accumulator.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_KEY_ACCUMULATOR_H_
 #define V8_KEY_ACCUMULATOR_H_
 
 #include "src/isolate.h"
 #include "src/objects.h"
 
@@ skipping 18 matching lines @@
 // Only unique keys are kept by the KeyAccumulator, strings are stored in a
 // HashSet for inexpensive lookups. Integer keys are kept in sorted lists which
 // are more compact and allow for reasonably fast includes check.
 class KeyAccumulator final BASE_EMBEDDED {
  public:
   KeyAccumulator(Isolate* isolate, PropertyFilter filter)
       : isolate_(isolate), filter_(filter) {}
   ~KeyAccumulator();
 
   bool AddKey(uint32_t key);
-  bool AddKey(Object* key, AddKeyConversion convert = DO_NOT_CONVERT);

[Jakob Kummerow, 2016/01/26 14:21:24]

Forcing callers to think about what behavior they want is better than silently
doing the wrong default thing.

[Toon Verwaest, 2016/01/27 15:02:21]

Acknowledged.

-  bool AddKey(Handle<Object> key, AddKeyConversion convert = DO_NOT_CONVERT);
-  void AddKeys(Handle<FixedArray> array,
-               AddKeyConversion convert = DO_NOT_CONVERT);
-  void AddKeys(Handle<JSObject> array,
-               AddKeyConversion convert = DO_NOT_CONVERT);
+  bool AddKey(Object* key, AddKeyConversion convert);
+  bool AddKey(Handle<Object> key, AddKeyConversion convert);
+  void AddKeys(Handle<FixedArray> array, AddKeyConversion convert);
+  void AddKeys(Handle<JSObject> array, AddKeyConversion convert);
   void AddKeysFromProxy(Handle<JSObject> array);
   Maybe<bool> AddKeysFromProxy(Handle<JSProxy> proxy, Handle<FixedArray> keys);
   void AddElementKeysFromInterceptor(Handle<JSObject> array);
   // Jump to the next level, pushing the current |levelLength_| to
   // |levelLengths_| and adding a new list to |elements_|.
   void NextPrototype();
   // Sort the integer indices in the last list in |elements_|
   void SortCurrentElementsList();
   Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
   int length() { return length_; }
@@ skipping 29 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 
 #endif  // V8_KEY_ACCUMULATOR_H_